From 8ca3b33cd8943d5ada3d977b96268d452433aaa2 Mon Sep 17 00:00:00 2001 From: zhiru Date: Mon, 15 Jul 2019 10:41:22 +0800 Subject: [PATCH 1/2] return AlreadyExist error Former-commit-id: b80220e68e8a5a53c1a2fef4e90d8a4729a85996 --- cpp/src/db/MySQLMetaImpl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/db/MySQLMetaImpl.cpp b/cpp/src/db/MySQLMetaImpl.cpp index bd82e7e6a1..9aa5a85e9e 100644 --- a/cpp/src/db/MySQLMetaImpl.cpp +++ b/cpp/src/db/MySQLMetaImpl.cpp @@ -347,7 +347,7 @@ namespace meta { return Status::Error("Table already exists and it is in delete state, please wait a second"); } else { - return Status::OK();//table already exists, no error + return Status::AlreadyExist("Table already exists"); } } } From 4d51f9a122a15a121e63eb84bbc7b0d200140a25 Mon Sep 17 00:00:00 2001 From: zhiru Date: Mon, 15 Jul 2019 10:45:20 +0800 Subject: [PATCH 2/2] Return AlreadyExist status in MySQLMetaImpl::CreateTable if table already exists Former-commit-id: eb56307b2a6613a90df28fba0f63166745195cc3 --- cpp/CHANGELOG.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cpp/CHANGELOG.md b/cpp/CHANGELOG.md index 7e7f88a2e9..946e08e99c 100644 --- a/cpp/CHANGELOG.md +++ b/cpp/CHANGELOG.md @@ -12,6 +12,7 @@ Please mark all change in change log and use the ticket from JIRA. - MS-153 - fix c_str error when connecting to MySQL - MS-157 - fix changelog - MS-190 - use env variable to switch mem manager and fix cmake +- MS-224 - Return AlreadyExist status in MySQLMetaImpl::CreateTable if table already exists ## Improvement - MS-156 - Add unittest for merge result functions @@ -21,11 +22,9 @@ Please mark all change in change log and use the ticket from JIRA. - MS-208 - Add buildinde interface for C++ SDK - MS-212 - Support Inner product metric type -## New Feature -- MS-195 - Add nlist and use_blas_threshold conf - ## New Feature - MS-180 - Add new mem manager +- MS-195 - Add nlist and use_blas_threshold conf ## Task