admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Set max read concurrency ratio to improve concurrent read performance (#18911)

Browse Source 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
This commit is contained in:
bigsheeper 2022-08-30 19:50:57 +08:00 committed by GitHub
parent 0a85097ba1
commit 5eb6127fc5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
configs/milvus.yaml
View File

@ -207,7 +207,11 @@ queryNode:
scheduler:
receiveChanSize: 10240
unsolvedQueueSize: 10240
maxReadConcurrency: 0 # maximum concurrency of read task. if set to less or equal 0, it means no uppper limit.
# maxReadConcurrentRatio is the concurrency ratio of read task (search task and query task).
# Max read concurrency would be the value of `runtime.NumCPU * maxReadConcurrentRatio`.
# It defaults to 2.0, which means max read concurrency would be the value of runtime.NumCPU * 2.
# Max read concurrency must greater than or equal to 1, and less than or equal to runtime.NumCPU * 100.
maxReadConcurrentRatio: 2.0 # (0, 100]
cpuRatio: 10.0 # ratio used to estimate read task cpu usage.
grouping:

11
internal/util/paramtable/component_param.go
View File

@ -13,6 +13,7 @@ package paramtable
import (
"math"
"runtime"
"strconv"
"strings"
"sync"
@ -870,9 +871,13 @@ func (p *queryNodeConfig) initCPURatio() {
}
func (p *queryNodeConfig) initMaxReadConcurrency() {
p.MaxReadConcurrency = p.Base.ParseInt32WithDefault("queryNode.scheduler.maxReadConcurrency", 0)
if p.MaxReadConcurrency <= 0 {
p.MaxReadConcurrency = math.MaxInt32
readConcurrencyRatio := p.Base.ParseFloatWithDefault("queryNode.scheduler.maxReadConcurrentRatio", 2.0)
cpuNum := int32(runtime.GOMAXPROCS(0))
p.MaxReadConcurrency = int32(float64(cpuNum) * readConcurrencyRatio)
if p.MaxReadConcurrency < 1 {
p.MaxReadConcurrency = 1 // MaxReadConcurrency must >= 1
} else if p.MaxReadConcurrency > cpuNum*100 {
p.MaxReadConcurrency = cpuNum * 100 // MaxReadConcurrency must <= 100*cpuNum
}
}

4
internal/util/paramtable/component_param_test.go
View File

@ -12,7 +12,7 @@
package paramtable
import (
"math"
"runtime"
"testing"
"time"
@ -245,7 +245,7 @@ func TestComponentParam(t *testing.T) {
assert.Equal(t, true, Params.GroupEnabled)
assert.Equal(t, int32(10240), Params.MaxReceiveChanSize)
assert.Equal(t, int32(10240), Params.MaxUnsolvedQueueSize)
assert.Equal(t, int32(math.MaxInt32), Params.MaxReadConcurrency)
assert.Equal(t, int32(runtime.GOMAXPROCS(0)*2), Params.MaxReadConcurrency)
assert.Equal(t, int64(1000), Params.MaxGroupNQ)
assert.Equal(t, 10.0, Params.TopKMergeRatio)
assert.Equal(t, 10.0, Params.CPURatio)