From 5ab3c562dada981f987d2c78f37de5d0a9fa5cb3 Mon Sep 17 00:00:00 2001
From: XuanYang-cn <xuan.yang@zilliz.com>
Date: Tue, 12 Nov 2024 21:18:29 +0800
Subject: [PATCH] enhance: tidy compaction logs (#37595)

Remove some annoying logs and lower a log level from warn to info

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
---
 internal/datacoord/compaction_policy_l0.go     |  1 -
 internal/datacoord/compaction_policy_single.go | 17 ++++++++++-------
 internal/datacoord/compaction_task_mix.go      |  2 +-
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/internal/datacoord/compaction_policy_l0.go b/internal/datacoord/compaction_policy_l0.go
index 905d1e7339..59a8acadb1 100644
--- a/internal/datacoord/compaction_policy_l0.go
+++ b/internal/datacoord/compaction_policy_l0.go
@@ -30,7 +30,6 @@ func (policy *l0CompactionPolicy) Enable() bool {
 }
 
 func (policy *l0CompactionPolicy) Trigger() (map[CompactionTriggerType][]CompactionView, error) {
-	log.Info("start trigger l0CompactionPolicy...")
 	// support config hot refresh
 	events := policy.generateEventForLevelZeroViewChange()
 	if len(events) != 0 {
diff --git a/internal/datacoord/compaction_policy_single.go b/internal/datacoord/compaction_policy_single.go
index 8a59ee6e2d..6fabd2f610 100644
--- a/internal/datacoord/compaction_policy_single.go
+++ b/internal/datacoord/compaction_policy_single.go
@@ -47,7 +47,6 @@ func (policy *singleCompactionPolicy) Enable() bool {
 }
 
 func (policy *singleCompactionPolicy) Trigger() (map[CompactionTriggerType][]CompactionView, error) {
-	log.Info("start trigger singleCompactionPolicy...")
 	ctx := context.Background()
 	collections := policy.meta.GetCollections()
 
@@ -67,14 +66,14 @@ func (policy *singleCompactionPolicy) Trigger() (map[CompactionTriggerType][]Com
 
 func (policy *singleCompactionPolicy) triggerOneCollection(ctx context.Context, collectionID int64, manual bool) ([]CompactionView, int64, error) {
 	log := log.With(zap.Int64("collectionID", collectionID))
-	log.Info("start trigger single compaction")
 	collection, err := policy.handler.GetCollection(ctx, collectionID)
 	if err != nil {
-		log.Warn("fail to get collection from handler")
+		log.Warn("fail to apply singleCompactionPolicy, unable to get collection from handler",
+			zap.Error(err))
 		return nil, 0, err
 	}
 	if collection == nil {
-		log.Warn("collection not exist")
+		log.Warn("fail to apply singleCompactionPolicy, collection not exist")
 		return nil, 0, nil
 	}
 	if !isCollectionAutoCompactionEnabled(collection) {
@@ -84,7 +83,7 @@ func (policy *singleCompactionPolicy) triggerOneCollection(ctx context.Context,
 
 	newTriggerID, err := policy.allocator.AllocID(ctx)
 	if err != nil {
-		log.Warn("fail to allocate triggerID", zap.Error(err))
+		log.Warn("fail to apply singleCompactionPolicy, unable to allocate triggerID", zap.Error(err))
 		return nil, 0, err
 	}
 
@@ -106,7 +105,7 @@ func (policy *singleCompactionPolicy) triggerOneCollection(ctx context.Context,
 
 		collectionTTL, err := getCollectionTTL(collection.Properties)
 		if err != nil {
-			log.Warn("get collection ttl failed, skip to handle compaction")
+			log.Warn("failed to apply singleCompactionPolicy, get collection ttl failed")
 			return make([]CompactionView, 0), 0, err
 		}
 
@@ -124,7 +123,11 @@ func (policy *singleCompactionPolicy) triggerOneCollection(ctx context.Context,
 		}
 	}
 
-	log.Info("finish trigger single compaction", zap.Int("viewNum", len(views)))
+	if len(views) > 0 {
+		log.Info("succeeded to apply singleCompactionPolicy",
+			zap.Int64("triggerID", newTriggerID),
+			zap.Int("triggered view num", len(views)))
+	}
 	return views, newTriggerID, nil
 }
 
diff --git a/internal/datacoord/compaction_task_mix.go b/internal/datacoord/compaction_task_mix.go
index b028f7f66c..486e1c1934 100644
--- a/internal/datacoord/compaction_task_mix.go
+++ b/internal/datacoord/compaction_task_mix.go
@@ -78,7 +78,7 @@ func (t *mixCompactionTask) processPipelining() bool {
 		t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_pipelining), setNodeID(NullNodeID))
 		return false
 	}
-	log.Warn("mixCompactionTask notify compaction tasks to DataNode")
+	log.Info("mixCompactionTask notify compaction tasks to DataNode")
 
 	err = t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_executing))
 	if err != nil {