From 5a27642a514e08fb63804364cfbc76f11950d05b Mon Sep 17 00:00:00 2001
From: yhz <413554850@qq.com>
Date: Mon, 25 Nov 2019 15:02:51 +0800
Subject: [PATCH] fix test case bug

---
 tests/milvus_python_test/test_add_vectors.py |  3 ++-
 tests/milvus_python_test/test_index.py       | 10 +++++++++-
 tests/milvus_python_test/utils.py            | 12 ++++++------
 3 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/tests/milvus_python_test/test_add_vectors.py b/tests/milvus_python_test/test_add_vectors.py
index 7245d51ea2..7c9d9e691c 100644
--- a/tests/milvus_python_test/test_add_vectors.py
+++ b/tests/milvus_python_test/test_add_vectors.py
@@ -1300,7 +1300,8 @@ class TestNameInvalid(object):
         assert not status.OK()
 
     @pytest.mark.level(2)
-    def test_add_vectors_with_invalid_tag_name(self, connect, get_tag_name):
+    def test_add_vectors_with_invalid_tag_name(self, connect, get_table_name, get_tag_name):
+        table_name = get_table_name
         tag_name = get_tag_name
         vectors = gen_vectors(1, dim)
         status, result = connect.add_vectors(table_name, vectors, partition_tag=tag_name)
diff --git a/tests/milvus_python_test/test_index.py b/tests/milvus_python_test/test_index.py
index 39aadb9d33..108563691f 100644
--- a/tests/milvus_python_test/test_index.py
+++ b/tests/milvus_python_test/test_index.py
@@ -1209,8 +1209,16 @@ class TestCreateIndexParamsInvalid(object):
         logging.getLogger().info(index_params)
         status, ids = connect.add_vectors(table, vectors)
         # if not isinstance(index_type, int) or not isinstance(nlist, int):
-        with pytest.raises(Exception) as e:
+        try:
             status = connect.create_index(table, index_params)
+            assert not status.OK()
+            # no exception raised & status is OK. unexpected.
+            assert False
+        except (Exception, ):
+            pass
+        # with pytest.raises(Exception) as e:
+        #     status = connect.create_index(table, index_params)
+            # assert not status.OK()
         # else:
         #     status = connect.create_index(table, index_params)
         #     assert not status.OK()
diff --git a/tests/milvus_python_test/utils.py b/tests/milvus_python_test/utils.py
index 159c8407c6..a0e60e5f9d 100644
--- a/tests/milvus_python_test/utils.py
+++ b/tests/milvus_python_test/utils.py
@@ -54,12 +54,12 @@ def gen_long_str(num):
 
 def gen_invalid_ips():
     ips = [
-            "255.0.0.0",
-            "255.255.0.0",
-            "255.255.255.0",
-            "255.255.255.255",
-            "127.0.0",
-            "123.0.0.2",
+            # "255.0.0.0",
+            # "255.255.0.0",
+            # "255.255.255.0",
+            # "255.255.255.255",
+            # "127.0.0",
+            # "123.0.0.2",
             "12-s",
             " ",
             "12 s",