From 57bd3e2181b94a0184ede305dc5b68f029de929f Mon Sep 17 00:00:00 2001 From: wei liu Date: Wed, 17 Jan 2024 19:12:54 +0800 Subject: [PATCH] fix: Leader checker canot submit load task (#30067) issue: #29841 if segment loaded, submit load segment task for it isn't permitted, to avoid load segment twice. but this logic blocks the leader checker to correct leader view by `LoadSegment` This PR remove the segment loaded check, to fix that leader checker cann't submit load task Signed-off-by: Wei Liu --- internal/querycoordv2/task/scheduler.go | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/internal/querycoordv2/task/scheduler.go b/internal/querycoordv2/task/scheduler.go index f8e2dab0b2..a35be5ad3e 100644 --- a/internal/querycoordv2/task/scheduler.go +++ b/internal/querycoordv2/task/scheduler.go @@ -329,14 +329,7 @@ func (scheduler *taskScheduler) preAdd(task Task) error { taskType := GetTaskType(task) - if taskType == TaskTypeGrow { - leaderSegmentDist := scheduler.distMgr.LeaderViewManager.GetSealedSegmentDist(task.SegmentID()) - nodeSegmentDist := scheduler.distMgr.SegmentDistManager.GetSegmentDist(task.SegmentID()) - if lo.Contains(leaderSegmentDist, task.Actions()[0].Node()) && - lo.Contains(nodeSegmentDist, task.Actions()[0].Node()) { - return merr.WrapErrServiceInternal("segment loaded, it can be only balanced") - } - } else if taskType == TaskTypeMove { + if taskType == TaskTypeMove { leaderSegmentDist := scheduler.distMgr.LeaderViewManager.GetSealedSegmentDist(task.SegmentID()) nodeSegmentDist := scheduler.distMgr.SegmentDistManager.GetSegmentDist(task.SegmentID()) if !lo.Contains(leaderSegmentDist, task.Actions()[1].Node()) ||