From 577e25a542ee94771017a5461125e333f48cfaa5 Mon Sep 17 00:00:00 2001 From: yanliang567 <82361606+yanliang567@users.noreply.github.com> Date: Fri, 17 Dec 2021 18:52:28 +0800 Subject: [PATCH] [skip e2e]Add comments for skip e2e tag (#13581) Signed-off-by: yanliang567 --- CODE_REVIEW.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CODE_REVIEW.md b/CODE_REVIEW.md index 20d1e0463c..8e76601294 100644 --- a/CODE_REVIEW.md +++ b/CODE_REVIEW.md @@ -4,7 +4,9 @@ All PRs are checked in automatically by the sre-robot, with the following condit 1. DCO check passed 2. All test passed and code coverage check passed, with a `ci-passed` label -3. Reviewe passed, with a `lgtm` label + - Notes: If there is a `[skip e2e]` tag in the commit message, it skips running e2e tests automatically, + but it still runs UT tests and code checkers. +3. Reviewer passed, with a `lgtm` label 4. Approver passed, with a `approved` label Generally speaking, reviewer is volunteered and can be anyone in the community who is familiar with the packages the PR modifies. @@ -43,6 +45,9 @@ all Approvers are listed under OWNERS_ALIASES file. - Are hacks, workarounds and temporary fixes commented? +- If `[skip e2e]` is tagged, is it safe enough to skip running e2e tests? + - Notes: it skips running e2e tests, if there is a `[skip e2e]` in the commit message. + ## Things to keep in mind when you are writing a review comment - Be kind to the coder, not to the code.