admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-07 09:38:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: dropped segment in excluded segment use wrong excluded ts (#43115)

Browse Source 
cause some excluded growing data insert again
relate: https://github.com/milvus-io/milvus/issues/43114

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
This commit is contained in:
aoiasd 2025-07-08 18:04:46 +08:00 committed by GitHub
parent d41eec6f10
commit 54cc0b60f2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/querynodev2/delegator/delegator_data.go
View File

@ -139,7 +139,13 @@ func (sd *shardDelegator) ProcessInsert(insertRecords map[int64]*InsertData) {
if newGrowingSegment { if newGrowingSegment {
sd.growingSegmentLock.Lock() sd.growingSegmentLock.Lock()
// check whether segment has been excluded // check whether segment has been excluded
if ok := sd.VerifyExcludedSegments(segmentID, typeutil.MaxTimestamp); !ok { // all segment in excluded segment should not be add again
// don not check excluded ts
// because dropped segment in excluded segment may use wrong excluded ts
// which use checkpoint ts as excluded ts
// but checkpoint_ts < segment_end_ts cause exclueded data is not filtered out at filter node
// should be excluded here
if ok := sd.VerifyExcludedSegments(segmentID, 0); !ok {
log.Warn("try to insert data into released segment, skip it", zap.Int64("segmentID", segmentID)) log.Warn("try to insert data into released segment, skip it", zap.Int64("segmentID", segmentID))
sd.growingSegmentLock.Unlock() sd.growingSegmentLock.Unlock()
growing.Release(context.Background()) growing.Release(context.Background())