admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix handoff segment unit test uses wrong node id (#18137)

Browse Source 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2022-07-07 15:22:21 +08:00 committed by GitHub
parent 0ad15a22c8
commit 543197c2be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/querynode/shard_cluster_test.go
View File

@ -1882,16 +1882,17 @@ func TestShardCluster_HandoffSegments(t *testing.T) {
}, buildMockQueryNode)
defer sc.Close()
// init first version
sc.SyncSegments(segmentEventsToSyncInfo(nil), segmentStateLoaded)
// add rc to all segments
// add rc to current version
_, versionID := sc.segmentAllocations(nil)
sig := make(chan struct{})
go func() {
err := sc.HandoffSegments(&querypb.SegmentChangeInfo{
OnlineSegments: []*querypb.SegmentInfo{
{SegmentID: 1, NodeID: 2, CollectionID: collectionID, DmChannel: vchannelName, NodeIds: []UniqueID{1}},
{SegmentID: 1, NodeID: 2, CollectionID: collectionID, DmChannel: vchannelName, NodeIds: []UniqueID{2}},
},
OfflineSegments: []*querypb.SegmentInfo{
{SegmentID: 1, NodeID: 1, CollectionID: collectionID, DmChannel: vchannelName, NodeIds: []UniqueID{1}},
@ -1910,7 +1911,7 @@ func TestShardCluster_HandoffSegments(t *testing.T) {
}
sc.finishUsage(versionID)
// wait for handoff appended into list
// after handoff, the version id shall be changed
assert.Eventually(t, func() bool {
sc.mut.RLock()
defer sc.mut.RUnlock()
@ -1926,8 +1927,6 @@ func TestShardCluster_HandoffSegments(t *testing.T) {
}
}
sc.finishUsage(tmpVersionID)
// rc shall be 0 now
sc.finishUsage(versionID)
// wait handoff finished
<-sig