From 53646032d035f8b3380f7b3e21caa1d4b6bcc2e3 Mon Sep 17 00:00:00 2001 From: wayblink Date: Thu, 23 Nov 2023 20:42:23 +0800 Subject: [PATCH] fix: rootcoord_collection_num metric is twice the real value (#28666) #28665 Signed-off-by: wayblink --- internal/rootcoord/root_coord.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/rootcoord/root_coord.go b/internal/rootcoord/root_coord.go index 7405ac3d94..c07b945f12 100644 --- a/internal/rootcoord/root_coord.go +++ b/internal/rootcoord/root_coord.go @@ -978,7 +978,6 @@ func (c *Core) CreateCollection(ctx context.Context, in *milvuspb.CreateCollecti metrics.RootCoordDDLReqCounter.WithLabelValues("CreateCollection", metrics.SuccessLabel).Inc() metrics.RootCoordDDLReqLatency.WithLabelValues("CreateCollection").Observe(float64(tr.ElapseSpan().Milliseconds())) - metrics.RootCoordNumOfCollections.Inc() metrics.RootCoordDDLReqLatencyInQueue.WithLabelValues("CreateCollection").Observe(float64(t.queueDur.Milliseconds())) log.Ctx(ctx).Info("done to create collection", @@ -1028,7 +1027,6 @@ func (c *Core) DropCollection(ctx context.Context, in *milvuspb.DropCollectionRe metrics.RootCoordDDLReqCounter.WithLabelValues("DropCollection", metrics.SuccessLabel).Inc() metrics.RootCoordDDLReqLatency.WithLabelValues("DropCollection").Observe(float64(tr.ElapseSpan().Milliseconds())) - metrics.RootCoordNumOfCollections.Dec() metrics.RootCoordDDLReqLatencyInQueue.WithLabelValues("DropCollection").Observe(float64(t.queueDur.Milliseconds())) log.Ctx(ctx).Info("done to drop collection", zap.String("role", typeutil.RootCoordRole), @@ -1279,7 +1277,6 @@ func (c *Core) AlterCollection(ctx context.Context, in *milvuspb.AlterCollection metrics.RootCoordDDLReqCounter.WithLabelValues("AlterCollection", metrics.SuccessLabel).Inc() metrics.RootCoordDDLReqLatency.WithLabelValues("AlterCollection").Observe(float64(tr.ElapseSpan().Milliseconds())) - metrics.RootCoordNumOfCollections.Dec() metrics.RootCoordDDLReqLatencyInQueue.WithLabelValues("AlterCollection").Observe(float64(t.queueDur.Milliseconds())) log.Info("done to alter collection",