From 52a05831b54bcb688a2bb140638e60bafb8c20bf Mon Sep 17 00:00:00 2001 From: XuanYang-cn Date: Mon, 5 Jan 2026 15:27:24 +0800 Subject: [PATCH] enhance: Tidy build index logs (#46531) Signed-off-by: yangxuan --- internal/datanode/index/task_index.go | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/internal/datanode/index/task_index.go b/internal/datanode/index/task_index.go index 8e22f847d0..098170ff7a 100644 --- a/internal/datanode/index/task_index.go +++ b/internal/datanode/index/task_index.go @@ -221,8 +221,11 @@ func (it *indexBuildTask) PreExecute(ctx context.Context) error { } func (it *indexBuildTask) Execute(ctx context.Context) error { - log := log.Ctx(ctx).With(zap.String("clusterID", it.req.GetClusterID()), zap.Int64("buildID", it.req.GetBuildID()), - zap.Int64("collection", it.req.GetCollectionID()), zap.Int64("segmentID", it.req.GetSegmentID()), + log := log.Ctx(ctx).With( + zap.String("clusterID", it.req.GetClusterID()), + zap.Int64("buildID", it.req.GetBuildID()), + zap.Int64("collection", it.req.GetCollectionID()), + zap.Int64("segmentID", it.req.GetSegmentID()), zap.Int32("currentIndexVersion", it.req.GetCurrentIndexVersion())) indexType := it.newIndexParams[common.IndexTypeKey] @@ -298,11 +301,6 @@ func (it *indexBuildTask) Execute(ctx context.Context) error { LackBinlogRows: it.req.GetLackBinlogRows(), StorageVersion: it.req.GetStorageVersion(), } - - if it.pluginContext != nil { - buildIndexParams.StoragePluginContext = it.pluginContext - } - if buildIndexParams.StorageVersion == storage.StorageV2 { buildIndexParams.SegmentInsertFiles = util.GetSegmentInsertFiles( it.req.GetInsertLogs(), @@ -314,6 +312,11 @@ func (it *indexBuildTask) Execute(ctx context.Context) error { } log.Info("create index", zap.Any("buildIndexParams", buildIndexParams)) + // set plugin context after logging the indexParams to avoid logging sensitive data + if it.pluginContext != nil { + buildIndexParams.StoragePluginContext = it.pluginContext + } + it.index, err = indexcgowrapper.CreateIndex(ctx, buildIndexParams) if err != nil { if it.index != nil && it.index.CleanLocalData() != nil {