admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-02-02 01:06:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: the insert count is zero after set the pointer to nil (#29870) (#29881)

Browse Source 
this leads to the EntitiesNum metric would be never reduced

fix: #29766
pr: #29870

Signed-off-by: yah01 <yang.cen@zilliz.com>
This commit is contained in:
yah01 2024-01-12 10:20:51 +08:00 committed by GitHub
parent f0db26107c
commit 4edcd4d22b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/querynodev2/segments/segment.go
View File

@ -233,10 +233,6 @@ func (s *LocalSegment) InsertCount() int64 {
s.ptrLock.RLock()
defer s.ptrLock.RUnlock()
if !s.isValid() {
return 0
}
return s.insertCount.Load()
}
@ -987,5 +983,6 @@ func (s *LocalSegment) Release() {
zap.Int64("partitionID", s.partitionID),
zap.Int64("segmentID", s.ID()),
zap.String("segmentType", s.typ.String()),
zap.Int64("insertCount", s.InsertCount()),
)
}

15
internal/querynodev2/segments/segment_test.go
View File

@ -184,13 +184,14 @@ func (suite *SegmentSuite) TestLoadDupIndex() {
func (suite *SegmentSuite) TestSegmentReleased() {
suite.sealed.Release()
suite.sealed.ptrLock.RLock()
suite.False(suite.sealed.isValid())
suite.sealed.ptrLock.RUnlock()
suite.EqualValues(0, suite.sealed.InsertCount())
suite.EqualValues(0, suite.sealed.RowNum())
suite.EqualValues(0, suite.sealed.MemSize())
suite.False(suite.sealed.HasRawData(101))
sealed := suite.sealed
sealed.ptrLock.RLock()
suite.False(sealed.isValid())
sealed.ptrLock.RUnlock()
suite.EqualValues(0, sealed.RowNum())
suite.EqualValues(0, sealed.MemSize())
suite.False(sealed.HasRawData(101))
}
func TestSegment(t *testing.T) {