From 4e68c6d222ca15b1cde15f698df9917cba39f960 Mon Sep 17 00:00:00 2001
From: aoiasd <45024769+aoiasd@users.noreply.github.com>
Date: Tue, 17 Jun 2025 11:14:38 +0800
Subject: [PATCH] enhance: add test for new parameters in access log (#42546)

relate: https://github.com/milvus-io/milvus/issues/41801

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
---
 .../proxy/accesslog/info/grpc_info_test.go    | 49 +++++++++++++++++++
 .../proxy/accesslog/info/restful_info_test.go | 49 +++++++++++++++++++
 2 files changed, 98 insertions(+)

diff --git a/internal/proxy/accesslog/info/grpc_info_test.go b/internal/proxy/accesslog/info/grpc_info_test.go
index 3022112ee8..e8dcc09356 100644
--- a/internal/proxy/accesslog/info/grpc_info_test.go
+++ b/internal/proxy/accesslog/info/grpc_info_test.go
@@ -232,6 +232,55 @@ func (s *GrpcAccessInfoSuite) TestClusterPrefix() {
 	s.Equal(cluster, result[0])
 }
 
+func (s *GrpcAccessInfoSuite) TestNQ() {
+	nq := int64(10)
+	s.Equal(Unknown, Get(s.info, "$nq")[0])
+
+	s.info.req = &milvuspb.SearchRequest{
+		Nq: nq,
+	}
+	s.Equal(fmt.Sprintf("%d", nq), Get(s.info, "$nq")[0])
+
+	s.info.req = &milvuspb.HybridSearchRequest{
+		Requests: []*milvuspb.SearchRequest{{
+			Nq: nq,
+		}, {
+			Nq: nq,
+		}},
+	}
+	s.Equal("[\"10\", \"10\"]", Get(s.info, "$nq")[0])
+}
+
+func (s *GrpcAccessInfoSuite) TestSearchParams() {
+	params := []*commonpb.KeyValuePair{{Key: "test_key", Value: "test_value"}}
+
+	s.Equal(Unknown, Get(s.info, "$search_params")[0])
+
+	s.info.req = &milvuspb.SearchRequest{
+		SearchParams: params,
+	}
+
+	s.Equal(kvsToString(params), Get(s.info, "$search_params")[0])
+
+	s.info.req = &milvuspb.HybridSearchRequest{
+		Requests: []*milvuspb.SearchRequest{{SearchParams: params}, {SearchParams: params}},
+	}
+
+	s.Equal(listToString([]string{kvsToString(params), kvsToString(params)}), Get(s.info, "$search_params")[0])
+}
+
+func (s *GrpcAccessInfoSuite) TestQueryParams() {
+	params := []*commonpb.KeyValuePair{{Key: "test_key", Value: "test_value"}}
+
+	s.Equal(Unknown, Get(s.info, "$query_params")[0])
+
+	s.info.req = &milvuspb.QueryRequest{
+		QueryParams: params,
+	}
+
+	s.Equal(kvsToString(params), Get(s.info, "$query_params")[0])
+}
+
 func TestGrpcAccssInfo(t *testing.T) {
 	suite.Run(t, new(GrpcAccessInfoSuite))
 }
diff --git a/internal/proxy/accesslog/info/restful_info_test.go b/internal/proxy/accesslog/info/restful_info_test.go
index f2e49dd9dc..014a33ed19 100644
--- a/internal/proxy/accesslog/info/restful_info_test.go
+++ b/internal/proxy/accesslog/info/restful_info_test.go
@@ -204,6 +204,55 @@ func (s *RestfulAccessInfoSuite) TestClusterPrefix() {
 	s.Equal(cluster, result[0])
 }
 
+func (s *RestfulAccessInfoSuite) TestNQ() {
+	nq := int64(10)
+	s.Equal(Unknown, Get(s.info, "$nq")[0])
+
+	s.info.req = &milvuspb.SearchRequest{
+		Nq: nq,
+	}
+	s.Equal(fmt.Sprintf("%d", nq), Get(s.info, "$nq")[0])
+
+	s.info.req = &milvuspb.HybridSearchRequest{
+		Requests: []*milvuspb.SearchRequest{{
+			Nq: nq,
+		}, {
+			Nq: nq,
+		}},
+	}
+	s.Equal("[\"10\", \"10\"]", Get(s.info, "$nq")[0])
+}
+
+func (s *RestfulAccessInfoSuite) TestSearchParams() {
+	params := []*commonpb.KeyValuePair{{Key: "test_key", Value: "test_value"}}
+
+	s.Equal(Unknown, Get(s.info, "$search_params")[0])
+
+	s.info.req = &milvuspb.SearchRequest{
+		SearchParams: params,
+	}
+
+	s.Equal(kvsToString(params), Get(s.info, "$search_params")[0])
+
+	s.info.req = &milvuspb.HybridSearchRequest{
+		Requests: []*milvuspb.SearchRequest{{SearchParams: params}, {SearchParams: params}},
+	}
+
+	s.Equal(listToString([]string{kvsToString(params), kvsToString(params)}), Get(s.info, "$search_params")[0])
+}
+
+func (s *RestfulAccessInfoSuite) TestQueryParams() {
+	params := []*commonpb.KeyValuePair{{Key: "test_key", Value: "test_value"}}
+
+	s.Equal(Unknown, Get(s.info, "$query_params")[0])
+
+	s.info.req = &milvuspb.QueryRequest{
+		QueryParams: params,
+	}
+
+	s.Equal(kvsToString(params), Get(s.info, "$query_params")[0])
+}
+
 func TestRestfulAccessInfo(t *testing.T) {
 	suite.Run(t, new(RestfulAccessInfoSuite))
 }