admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-28 22:45:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve rocksmq CreateConsumerGroup log (#12473)

Browse Source 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2021-11-30 19:09:33 +08:00 committed by GitHub
parent 7f9a41496d
commit 4dd3dc7aa9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/util/rocksmq/server/rocksmq/rocksmq_impl.go
View File

@ -381,7 +381,7 @@ func (rmq *rocksmq) CreateConsumerGroup(topicName, groupName string) error {
start := time.Now()
key := constructCurrentID(topicName, groupName)
if rmq.checkKeyExist(key) {
log.Debug("RocksMQ: " + key + " existed.")
log.Debug("RMQ CreateConsumerGroup key already exists", zap.String("key", key))
return nil
}
err := rmq.kv.Save(key, DefaultMessageID)

3
internal/util/rocksmq/server/rocksmq/rocksmq_impl_test.go
View File

@ -179,6 +179,9 @@ func TestRocksmq(t *testing.T) {
_ = rmq.DestroyConsumerGroup(channelName, groupName)
err = rmq.CreateConsumerGroup(channelName, groupName)
assert.Nil(t, err)
// double create consumer group
err = rmq.CreateConsumerGroup(channelName, groupName)
assert.Nil(t, err)
cMsgs, err := rmq.Consume(channelName, groupName, 1)
assert.Nil(t, err)
assert.Equal(t, len(cMsgs), 1)