From 4dc9a64f01492b64f4164d46bbd77541d8157adb Mon Sep 17 00:00:00 2001 From: Cai Yudong Date: Tue, 14 Sep 2021 16:07:48 +0800 Subject: [PATCH] Improve segcore code readability (#7868) Signed-off-by: yudong.cai --- internal/core/src/segcore/InsertRecord.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/internal/core/src/segcore/InsertRecord.h b/internal/core/src/segcore/InsertRecord.h index c59e4a685e..d9c8004506 100644 --- a/internal/core/src/segcore/InsertRecord.h +++ b/internal/core/src/segcore/InsertRecord.h @@ -27,8 +27,7 @@ struct InsertRecord { explicit InsertRecord(const Schema& schema, int64_t size_per_chunk); // get field data without knowing the type - // return VectorBase type - auto + VectorBase* get_field_data_base(FieldOffset field_offset) const { auto ptr = field_datas_[field_offset.get()].get(); return ptr; @@ -36,7 +35,7 @@ struct InsertRecord { // get field data in given type, const version template - auto + const ConcurrentVector* get_field_data(FieldOffset field_offset) const { auto base_ptr = get_field_data_base(field_offset); auto ptr = dynamic_cast*>(base_ptr); @@ -44,9 +43,9 @@ struct InsertRecord { return ptr; } - // get field data in given type, nonconst version + // get field data in given type, non-const version template - auto + ConcurrentVector* get_field_data(FieldOffset field_offset) { auto base_ptr = get_field_data_base(field_offset); auto ptr = dynamic_cast*>(base_ptr);