admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-07 09:38:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add opentrace log for index component (#7946)

Browse Source 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
This commit is contained in:
cai.zhang 2021-09-16 10:07:48 +08:00 committed by GitHub
parent b465e8f9a4
commit 4814f9cb1c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/distributed/indexcoord/service.go
View File

@ -69,7 +69,7 @@ func (s *Server) init() error {
indexcoord.Params.Address = Params.ServiceAddress indexcoord.Params.Address = Params.ServiceAddress
indexcoord.Params.Port = Params.ServicePort indexcoord.Params.Port = Params.ServicePort
closer := trace.InitTracing("index_coord") closer := trace.InitTracing("IndexCoord")
s.closer = closer s.closer = closer
if err := s.indexcoord.Register(); err != nil { if err := s.indexcoord.Register(); err != nil {

2
internal/distributed/indexnode/service.go
View File

@ -104,7 +104,7 @@ func (s *Server) init() error {
indexnode.Params.IP = Params.IP indexnode.Params.IP = Params.IP
indexnode.Params.Address = Params.Address indexnode.Params.Address = Params.Address
closer := trace.InitTracing(fmt.Sprintf("index_node ip: %s, port: %d", Params.IP, Params.Port)) closer := trace.InitTracing(fmt.Sprintf("IndexNode-%d", indexnode.Params.NodeID))
s.closer = closer s.closer = closer
Params.Address = Params.IP + ":" + strconv.FormatInt(int64(Params.Port), 10) Params.Address = Params.IP + ":" + strconv.FormatInt(int64(Params.Port), 10)

4
internal/indexcoord/index_coord.go
View File

@ -342,14 +342,13 @@ func (i *IndexCoord) BuildIndex(ctx context.Context, req *indexpb.BuildIndexRequ
return i.sched.IndexAddQueue.Enqueue(t) return i.sched.IndexAddQueue.Enqueue(t)
} }
} }
err := fn() err := fn()
if err != nil { if err != nil {
ret.Status.ErrorCode = commonpb.ErrorCode_UnexpectedError ret.Status.ErrorCode = commonpb.ErrorCode_UnexpectedError
ret.Status.Reason = err.Error() ret.Status.Reason = err.Error()
return ret, nil return ret, nil
} }
log.Debug("IndexCoord BuildIndex Enqueue successfully", zap.Any("IndexBuildID", indexBuildID)) log.Debug("IndexCoord BuildIndex Enqueue successfully", zap.Any("IndexBuildID", t.indexBuildID))
err = t.WaitToFinish() err = t.WaitToFinish()
if err != nil { if err != nil {
@ -357,6 +356,7 @@ func (i *IndexCoord) BuildIndex(ctx context.Context, req *indexpb.BuildIndexRequ
ret.Status.Reason = err.Error() ret.Status.Reason = err.Error()
return ret, nil return ret, nil
} }
sp.SetTag("IndexCoord-IndexBuildID", strconv.FormatInt(t.indexBuildID, 10))
ret.Status.ErrorCode = commonpb.ErrorCode_Success ret.Status.ErrorCode = commonpb.ErrorCode_Success
ret.IndexBuildID = t.indexBuildID ret.IndexBuildID = t.indexBuildID
return ret, nil return ret, nil

3
internal/indexnode/indexnode.go
View File

@ -175,8 +175,9 @@ func (i *IndexNode) CreateIndex(ctx context.Context, request *indexpb.CreateInde
zap.Any("TypeParams", request.TypeParams), zap.Any("TypeParams", request.TypeParams),
zap.Any("IndexParams", request.IndexParams)) zap.Any("IndexParams", request.IndexParams))
sp, ctx := trace.StartSpanFromContextWithOperationName(ctx, "CreateIndex") sp, ctx := trace.StartSpanFromContextWithOperationName(ctx, "IndexNode-CreateIndex")
defer sp.Finish() defer sp.Finish()
sp.SetTag("IndexBuildID", strconv.FormatInt(request.IndexBuildID, 10))
t := &IndexBuildTask{ t := &IndexBuildTask{
BaseTask: BaseTask{ BaseTask: BaseTask{