fix: wrong update timetick of collection meta info (#45461)

issue: #45403, #45463

- fix the Nightly E2E failures.
- fix the wrong update timetick of altering collection to fix the
related load failure.

Signed-off-by: chyezh <chyezh@outlook.com>

internal/rootcoord/meta_table.go

@@ -957,7 +957,7 @@ func (mt *MetaTable) AlterCollection(ctx context.Context, result message.Broadca
 			dbChanged = true
 		}
 	}
-	newColl.UpdateTimestamp = result.GetControlChannelResult().TimeTick
+	newColl.UpdateTimestamp = result.GetMaxTimeTick()
 
 	ctx1 := contextutil.WithTenantID(ctx, Params.CommonCfg.ClusterName.GetValue())
 	if !dbChanged {

pkg/streaming/util/message/broadcast.go

@@ -33,6 +33,17 @@ type BroadcastResult[H proto.Message, B proto.Message] struct {
 	Results map[string]*AppendResult
 }
 
+// GetMaxTimeTick returns the max time tick of the broadcast result.
+func (br *BroadcastResult[H, B]) GetMaxTimeTick() uint64 {
+	maxTimeTick := uint64(0)
+	for _, result := range br.Results {
+		if result.TimeTick > maxTimeTick {
+			maxTimeTick = result.TimeTick
+		}
+	}
+	return maxTimeTick
+}
+
 // GetControlChannelResult returns the append result of the control channel.
 // Return nil if the control channel is not found.
 func (br *BroadcastResult[H, B]) GetControlChannelResult() *AppendResult {

pkg/streaming/util/message/broadcast_test.go

@@ -12,12 +12,13 @@ func TestBroadcastResult(t *testing.T) {
 	r := BroadcastResult[*CreateDatabaseMessageHeader, *CreateDatabaseMessageBody]{
 		Message: nil,
 		Results: map[string]*AppendResult{
-			"v1":                                  {},
+			"v1":                                  {TimeTick: 1},
-			"v2":                                  {},
+			"v2":                                  {TimeTick: 2},
-			"abc" + funcutil.ControlChannelSuffix: {},
+			"abc" + funcutil.ControlChannelSuffix: {TimeTick: 3},
 		},
 	}
 
 	assert.ElementsMatch(t, []string{"v1", "v2"}, r.GetVChannelsWithoutControlChannel())
 	assert.NotNil(t, r.GetControlChannelResult())
+	assert.Equal(t, uint64(3), r.GetMaxTimeTick())
 }

tests/python_client/milvus_client/test_milvus_client_collection.py

@@ -3055,7 +3055,7 @@ class TestMilvusClientDescribeCollectionValid(TestMilvusClientV2Base):
             'functions': [], 
             'aliases': [], 
             'consistency_level': 0, 
-            'properties': {'collection.timezone': 'UTC'},
+            'properties': {'timezone': 'UTC'},
             'num_partitions': 1, 
             'enable_dynamic_field': True
         }
@@ -3345,8 +3345,7 @@ class TestMilvusClientRenameCollectionInValid(TestMilvusClientV2Base):
         collection_name = cf.gen_unique_str(prefix)
         # 1. create collection
         self.create_collection(client, collection_name, default_dim)
-        error = {ct.err_code: 65535, ct.err_msg: f"duplicated new collection name {collection_name} in database "
+        error = {ct.err_code: 1100, ct.err_msg: f"collection name or database name should be different"}
-                                                 f"default with other collection name or alias"}
         self.rename_collection(client, collection_name, collection_name,
                                check_task=CheckTasks.err_res, check_items=error)
 
@@ -3529,8 +3528,7 @@ class TestMilvusClientCollectionPropertiesInvalid(TestMilvusClientV2Base):
                                  check_items={"collection_name": collection_name,
                                               "dim": default_dim,
                                               "consistency_level": 0})
-        error = {ct.err_code: 65535, ct.err_msg: f"alter collection with empty properties and "
+        error = {ct.err_code: 1100, ct.err_msg: f"no properties or delete keys provided"}
-                                                 f"delete keys, expect to set either properties or delete keys"}
         self.drop_collection_properties(client, collection_name, property_keys,
                                         check_task=CheckTasks.err_res,
                                         check_items=error)

tests/python_client/milvus_client/test_milvus_client_timestamptz.py

@@ -446,7 +446,7 @@ class TestMilvusClientTimestamptzValid(TestMilvusClientV2Base):
                                consistency_level="Strong", index_params=index_params)
         
         # step 2: alter collection properties
-        self.alter_collection_properties(client, collection_name, properties={"collection.timezone": "Asia/Shanghai"})
+        self.alter_collection_properties(client, collection_name, properties={"timezone": "Asia/Shanghai"})
         rows = cf.gen_row_data_by_schema(nb=default_nb, schema=schema)
         self.insert(client, collection_name, rows)
         

tests/python_client/testcases/test_utility.py

@@ -512,8 +512,7 @@ class TestUtilityParams(TestcaseBase):
         self.utility_wrap.rename_collection(old_collection_name, new_collection_name,
                                             check_task=CheckTasks.err_res,
                                             check_items={"err_code": 100,
-                                                         "err_msg": "collection not found in database, collection: {}"
+                                                         "err_msg": "collection not found"})
-                                                                    ", database: default".format(old_collection_name)})
 
     @pytest.mark.tags(CaseLabel.L1)
     def test_rename_collection_existed_collection_name(self):