admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-06 17:18:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix unstable TestSingleflight unit test (#26363)

Browse Source 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2023-08-16 10:07:33 +08:00 committed by GitHub
parent a12e45f693
commit 4742049ecf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
pkg/util/conc/singleflight_test.go
View File

@ -68,26 +68,21 @@ func (s *SingleflightSuite) TestDoChan() {
} }
func (s *SingleflightSuite) TestForget() { func (s *SingleflightSuite) TestForget() {
counter, hasShared := atomic.Int32{}, atomic.Bool{}
sf := Singleflight[any]{} sf := Singleflight[any]{}
ch := make(chan struct{}) ch := make(chan struct{})
submitted := make(chan struct{})
var wg sync.WaitGroup var wg sync.WaitGroup
wg.Add(10) wg.Add(1)
for i := 0; i < 10; i++ { go func() {
go func(i int) { sf.Do("test_forget", func() (any, error) {
defer wg.Done() defer wg.Done()
_, _, shared := sf.Do("test_forget", func() (any, error) { close(submitted)
<-ch <-ch
counter.Add(1) return struct{}{}, nil
return struct{}{}, nil })
}) }()
if shared {
hasShared.Store(true)
}
}(i)
}
<-submitted
flag := false flag := false
sf.Forget("test_forget") sf.Forget("test_forget")
sf.Do("test_forget", func() (any, error) { sf.Do("test_forget", func() (any, error) {
@ -98,7 +93,7 @@ func (s *SingleflightSuite) TestForget() {
close(ch) close(ch)
wg.Wait() wg.Wait()
s.True(flag) s.True(flag, "new job shall be executed after forget")
} }
func TestSingleFlight(t *testing.T) { func TestSingleFlight(t *testing.T) {