From 445f5426d1a6728ebc29ac63e084f1ccec3a378c Mon Sep 17 00:00:00 2001 From: godchen Date: Thu, 7 Oct 2021 22:16:56 +0800 Subject: [PATCH] Check data node error (#9303) Signed-off-by: godchen --- internal/datanode/data_node.go | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/internal/datanode/data_node.go b/internal/datanode/data_node.go index 0c4f75df3c..7f39337e3c 100644 --- a/internal/datanode/data_node.go +++ b/internal/datanode/data_node.go @@ -205,7 +205,10 @@ func (node *DataNode) StartWatchChannels(ctx context.Context) { log.Warn("Watch channel failed", zap.Error(event.Err())) // if watch loop return due to event canceled, the datanode is not functional anymore // stop the datanode and wait for restart - node.Stop() + err := node.Stop() + if err != nil { + log.Warn("node stop failed", zap.Error(err)) + } return } for _, evt := range event.Events { @@ -370,7 +373,10 @@ func (node *DataNode) Start() error { go node.BackGroundGC(node.clearSignal) go node.session.LivenessCheck(node.ctx, node.liveCh, func() { - node.Stop() + err := node.Stop() + if err != nil { + log.Warn("node stop failed", zap.Error(err)) + } }) Params.CreatedTime = time.Now() @@ -575,7 +581,10 @@ func (node *DataNode) Stop() error { } if node.closer != nil { - node.closer.Close() + err := node.closer.Close() + if err != nil { + return err + } } return nil }