admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-08 18:18:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Enhance querycoord log (#10523)

Browse Source 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
This commit is contained in:
zhenshan.cao 2021-10-24 15:16:00 +08:00 committed by GitHub
parent 7acb48919b
commit 40750f03c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Makefile
View File

@ -111,6 +111,11 @@ build-cpp-with-unittest:
# Run the tests. # Run the tests.
unittest: test-cpp test-go unittest: test-cpp test-go
test-proxy:
@echo "Running go unittests..."
go test -race -coverpkg=./... -coverprofile=profile.out -covermode=atomic -timeout 5m github.com/milvus-io/milvus/internal/proxy -v
test-go: build-cpp-with-unittest test-go: build-cpp-with-unittest
@echo "Running go unittests..." @echo "Running go unittests..."
@(env bash $(PWD)/scripts/run_go_codecov.sh) @(env bash $(PWD)/scripts/run_go_codecov.sh)

2
internal/querycoord/task.go
View File

@ -1356,7 +1356,7 @@ func (wqt *watchQueryChannelTask) execute(ctx context.Context) error {
err := wqt.cluster.addQueryChannel(wqt.ctx, wqt.NodeID, wqt.AddQueryChannelRequest) err := wqt.cluster.addQueryChannel(wqt.ctx, wqt.NodeID, wqt.AddQueryChannelRequest)
if err != nil { if err != nil {
log.Warn("watchQueryChannelTask: watchQueryChannel occur error", zap.Int64("taskID", wqt.getTaskID())) log.Warn("watchQueryChannelTask: watchQueryChannel occur error", zap.Int64("taskID", wqt.getTaskID()), zap.Error(err))
wqt.setResultInfo(err) wqt.setResultInfo(err)
return err return err
} }

2
internal/querynode/collection_replica.go
View File

@ -182,7 +182,7 @@ func (colReplica *collectionReplica) getCollectionByID(collectionID UniqueID) (*
func (colReplica *collectionReplica) getCollectionByIDPrivate(collectionID UniqueID) (*Collection, error) { func (colReplica *collectionReplica) getCollectionByIDPrivate(collectionID UniqueID) (*Collection, error) {
collection, ok := colReplica.collections[collectionID] collection, ok := colReplica.collections[collectionID]
if !ok { if !ok {
return nil, errors.New("collection hasn't been loaded or has been released, collection id = %d" + strconv.FormatInt(collectionID, 10)) return nil, errors.New("collection hasn't been loaded or has been released, collection id =" + strconv.FormatInt(collectionID, 10))
} }
return collection, nil return collection, nil