admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong log (#26022)

Browse Source 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
This commit is contained in:
smellthemoon 2023-08-02 11:01:07 +08:00 committed by GitHub
parent 0727e017c4
commit 3fc18c53a3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/querynodev2/handlers.go
View File

@ -175,8 +175,8 @@ func (node *QueryNode) queryChannel(ctx context.Context, req *querypb.QueryReque
// get delegator
sd, ok := node.delegators.Get(channel)
if !ok {
err := merr.WrapErrServiceUnavailable("failed to get query shard delegator")
log.Warn("Query failed, failed to get query shard delegator", zap.Error(err))
err := merr.WrapErrServiceUnavailable("failed to get shard delegator for query")
log.Warn("Query failed, failed to get shard delegator for query", zap.Error(err))
failRet.Status = merr.Status(err)
return failRet, nil
}
@ -326,8 +326,8 @@ func (node *QueryNode) searchChannel(ctx context.Context, req *querypb.SearchReq
// get delegator
sd, ok := node.delegators.Get(channel)
if !ok {
err := merr.WrapErrServiceUnavailable("failed to get query shard delegator")
log.Warn("Query failed, failed to get query shard delegator", zap.Error(err))
err := merr.WrapErrServiceUnavailable("failed to get shard delegator for search")
log.Warn("Query failed, failed to get shard delegator for search", zap.Error(err))
failRet.Status.Reason = err.Error()
return failRet, err
}

4
internal/querynodev2/services_test.go
View File

@ -1170,7 +1170,7 @@ func (suite *ServiceSuite) TestSearch_Failed() {
resp, err = suite.node.Search(ctx, req)
suite.NoError(err)
suite.Equal(commonpb.ErrorCode_UnexpectedError, resp.GetStatus().GetErrorCode())
suite.Contains(resp.GetStatus().GetReason(), "failed to get query shard delegator")
suite.Contains(resp.GetStatus().GetReason(), merr.ErrServiceUnavailable.Error())
suite.TestWatchDmChannelsInt64()
suite.TestLoadSegments_Int64()
@ -1269,7 +1269,7 @@ func (suite *ServiceSuite) TestQuery_Failed() {
resp, err := suite.node.Query(ctx, req)
suite.NoError(err)
suite.Equal(commonpb.ErrorCode_UnexpectedError, resp.GetStatus().GetErrorCode())
suite.Contains(resp.GetStatus().GetReason(), "failed to get query shard delegator")
suite.Contains(resp.GetStatus().GetReason(), merr.ErrServiceUnavailable.Error())
suite.TestWatchDmChannelsInt64()
suite.TestLoadSegments_Int64()