admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix data race while updating segment version (#26387)

Browse Source 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
This commit is contained in:
yah01 2023-08-16 16:30:18 +08:00 committed by GitHub
parent 19f210974f
commit 3d8871b30e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/querynodev2/segments/segment.go
View File

@ -79,7 +79,7 @@ type baseSegment struct {
shard string
collectionID int64
typ SegmentType
version int64
version *atomic.Int64
startPosition *msgpb.MsgPosition // for growing segment release
bloomFilterSet *pkoracle.BloomFilterSet
}
@ -91,7 +91,7 @@ func newBaseSegment(id, partitionID, collectionID int64, shard string, typ Segme
collectionID: collectionID,
shard: shard,
typ: typ,
version: version,
version: atomic.NewInt64(version),
startPosition: startPosition,
bloomFilterSet: pkoracle.NewBloomFilterSet(id, partitionID, typ),
}
@ -123,11 +123,11 @@ func (s *baseSegment) StartPosition() *msgpb.MsgPosition {
}
func (s *baseSegment) Version() int64 {
return s.version
return s.version.Load()
}
func (s *baseSegment) UpdateVersion(version int64) {
s.version = version
s.version.Store(version)
}
func (s *baseSegment) UpdateBloomFilter(pks []storage.PrimaryKey) {