From 3c09a5f2e887fdda80d703e1d499577f4a2dd30c Mon Sep 17 00:00:00 2001 From: "cai.zhang" Date: Tue, 15 Nov 2022 19:55:07 +0800 Subject: [PATCH] Use GetSegmentUnsafe when get unhealthy segment (#20617) Signed-off-by: cai.zhang Signed-off-by: cai.zhang --- internal/datacoord/services.go | 2 +- internal/indexcoord/garbage_collector.go | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/internal/datacoord/services.go b/internal/datacoord/services.go index 009aeb7c9c..65292979d2 100644 --- a/internal/datacoord/services.go +++ b/internal/datacoord/services.go @@ -738,7 +738,7 @@ func (s *Server) GetFlushedSegments(ctx context.Context, req *datapb.GetFlushedS } ret := make([]UniqueID, 0, len(segmentIDs)) for _, id := range segmentIDs { - segment := s.meta.GetSegment(id) + segment := s.meta.GetSegmentUnsafe(id) // if this segment == nil, we assume this segment has been gc if segment == nil || (segment.GetState() != commonpb.SegmentState_Dropped && diff --git a/internal/indexcoord/garbage_collector.go b/internal/indexcoord/garbage_collector.go index 51389f8427..74bc276f2c 100644 --- a/internal/indexcoord/garbage_collector.go +++ b/internal/indexcoord/garbage_collector.go @@ -158,7 +158,7 @@ func (gc *garbageCollector) recycleSegIndexesMeta() { continue } if _, ok := flushedSegments[segID]; !ok { - log.Ctx(gc.ctx).Debug("segment is already not exist, mark it deleted", zap.Int64("collID", collID), + log.Ctx(gc.ctx).Info("segment is already not exist, mark it deleted", zap.Int64("collID", collID), zap.Int64("segID", segID)) if err := gc.metaTable.MarkSegmentsIndexAsDeleted(func(segIndex *model.SegmentIndex) bool { return segIndex.SegmentID == segID @@ -180,7 +180,8 @@ func (gc *garbageCollector) recycleSegIndexesMeta() { zap.Int64("nodeID", meta.NodeID), zap.Error(err)) continue } - log.Ctx(gc.ctx).Debug("index meta recycle success", zap.Int64("buildID", meta.BuildID)) + log.Ctx(gc.ctx).Info("index meta recycle success", zap.Int64("buildID", meta.BuildID), + zap.Int64("segID", meta.SegmentID)) } } }