diff --git a/internal/proxy/task.go b/internal/proxy/task.go index 501af2d6dd..fda1274f6c 100644 --- a/internal/proxy/task.go +++ b/internal/proxy/task.go @@ -1193,11 +1193,11 @@ func (cct *createCollectionTask) PreExecute(ctx context.Context) error { return errors.New("dimension is not defined in field type params, check type param `dim` for vector field") } if field.DataType == schemapb.DataType_FloatVector { - if err := ValidateDimension(dim, false); err != nil { + if err := validateDimension(dim, false); err != nil { return err } } else { - if err := ValidateDimension(dim, true); err != nil { + if err := validateDimension(dim, true); err != nil { return err } } diff --git a/internal/proxy/validate_util.go b/internal/proxy/validate_util.go index 79f604b516..3c048950bb 100644 --- a/internal/proxy/validate_util.go +++ b/internal/proxy/validate_util.go @@ -140,7 +140,7 @@ func validateFieldName(fieldName string) error { return nil } -func ValidateDimension(dim int64, isBinary bool) error { +func validateDimension(dim int64, isBinary bool) error { if dim <= 0 || dim > Params.MaxDimension { return fmt.Errorf("invalid dimension: %d. should be in range 1 ~ %d", dim, Params.MaxDimension) } diff --git a/internal/proxy/validate_util_test.go b/internal/proxy/validate_util_test.go index 7dfb467a04..a69b77c117 100644 --- a/internal/proxy/validate_util_test.go +++ b/internal/proxy/validate_util_test.go @@ -96,15 +96,15 @@ func TestValidateFieldName(t *testing.T) { } func TestValidateDimension(t *testing.T) { - assert.Nil(t, ValidateDimension(1, false)) - assert.Nil(t, ValidateDimension(Params.MaxDimension, false)) - assert.Nil(t, ValidateDimension(8, true)) - assert.Nil(t, ValidateDimension(Params.MaxDimension, true)) + assert.Nil(t, validateDimension(1, false)) + assert.Nil(t, validateDimension(Params.MaxDimension, false)) + assert.Nil(t, validateDimension(8, true)) + assert.Nil(t, validateDimension(Params.MaxDimension, true)) // invalid dim - assert.NotNil(t, ValidateDimension(-1, false)) - assert.NotNil(t, ValidateDimension(Params.MaxDimension+1, false)) - assert.NotNil(t, ValidateDimension(9, true)) + assert.NotNil(t, validateDimension(-1, false)) + assert.NotNil(t, validateDimension(Params.MaxDimension+1, false)) + assert.NotNil(t, validateDimension(9, true)) } func TestValidateVectorFieldMetricType(t *testing.T) {