admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Don't create index for unsorted importing segment when enable stats (#41864)

Browse Source 
issue: #41863

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
This commit is contained in:
cai.zhang 2025-05-19 10:52:23 +08:00 committed by GitHub
parent 7660be0993
commit 38ded7364f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/datacoord/index_service.go
View File

@ -61,10 +61,6 @@ func (s *Server) startIndexService(ctx context.Context) {
}
func (s *Server) createIndexForSegment(ctx context.Context, segment *SegmentInfo, indexID UniqueID) error {
if !segment.GetIsSorted() && Params.DataCoordCfg.EnableStatsTask.GetAsBool() && !segment.GetIsImporting() && segment.Level != datapb.SegmentLevel_L0 {
log.Info("segment not sorted, skip create index", zap.Int64("segmentID", segment.GetID()))
return nil
}
log.Info("create index for segment", zap.Int64("segmentID", segment.ID), zap.Int64("indexID", indexID))
buildID, err := s.allocator.AllocID(context.Background())
if err != nil {
@ -89,7 +85,7 @@ func (s *Server) createIndexForSegment(ctx context.Context, segment *SegmentInfo
}
func (s *Server) createIndexesForSegment(ctx context.Context, segment *SegmentInfo) error {
if Params.DataCoordCfg.EnableStatsTask.GetAsBool() && !segment.GetIsSorted() && !segment.GetIsImporting() {
if Params.DataCoordCfg.EnableStatsTask.GetAsBool() && !segment.GetIsSorted() {
log.Ctx(ctx).Debug("segment is not sorted by pk, skip create indexes", zap.Int64("segmentID", segment.GetID()))
return nil
}

18
internal/datacoord/server.go
View File

@ -877,16 +877,26 @@ func (s *Server) postFlush(ctx context.Context, segmentID UniqueID) error {
}
// set segment to SegmentState_Flushed
var operators []UpdateOperator
operators = append(operators, SetSegmentIsInvisible(segmentID, true))
if Params.DataCoordCfg.EnableStatsTask.GetAsBool() {
operators = append(operators, SetSegmentIsInvisible(segmentID, true))
}
operators = append(operators, UpdateStatusOperator(segmentID, commonpb.SegmentState_Flushed))
err := s.meta.UpdateSegmentsInfo(ctx, operators...)
if err != nil {
log.Warn("flush segment complete failed", zap.Error(err))
return err
}
select {
case getStatsTaskChSingleton() <- segmentID:
default:
if Params.DataCoordCfg.EnableStatsTask.GetAsBool() {
select {
case getStatsTaskChSingleton() <- segmentID:
default:
}
} else {
select {
case getBuildIndexChSingleton() <- segmentID:
default:
}
}
insertFileNum := 0

1
pkg/util/paramtable/component_param.go
View File

@ -4809,6 +4809,7 @@ if param targetVecIndexVersion is not set, the default value is -1, which means
DefaultValue: "true",
PanicIfEmpty: false,
Export: false,
Forbidden: true,
}
p.EnableStatsTask.Init(base.mgr)