admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-06 17:18:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: cpp format check not work (#30767)

Browse Source 
fix: #30765

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
This commit is contained in:
Jiquan Long 2024-02-22 19:40:53 +08:00 committed by GitHub
parent e5353ad049
commit 375190e76e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 49 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Makefile
View File

@ -100,7 +100,8 @@ tools/bin/revive: tools/check/go.mod
$(GO) build -o ../bin/revive github.com/mgechev/revive $(GO) build -o ../bin/revive github.com/mgechev/revive
cppcheck: cppcheck:
@(env bash ${PWD}/scripts/core_build.sh -l) @#(env bash ${PWD}/scripts/core_build.sh -l)
@(env bash ${PWD}/scripts/check_cpp_fmt.sh)
fmt: fmt:

47
scripts/check_cpp_fmt.sh Executable file
View File

@ -0,0 +1,47 @@
#!/usr/bin/env bash
# Licensed to the LF AI & Data foundation under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
SOURCE="${BASH_SOURCE[0]}"
while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symlink
DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
SOURCE="$(readlink "$SOURCE")"
[[ $SOURCE != /* ]] && SOURCE="$DIR/$SOURCE" # if $SOURCE was a relative symlink, we need to resolve it relative to the path where the symlink file was located
done
ROOT_DIR="$( cd -P "$( dirname "$SOURCE" )/.." && pwd )"
CPP_SRC_DIR="${ROOT_DIR}/internal/core"
pushd $CPP_SRC_DIR
./run_clang_format.sh .
popd
if [[ $(uname -s) == "Darwin" ]]; then
if ! brew --prefix --installed grep >/dev/null 2>&1; then
brew install grep
fi
export PATH="/usr/local/opt/grep/libexec/gnubin:$PATH"
fi
check_result=$(git status | grep -E "*\.h|*\.hpp|*\.cc|*\.cpp")
echo "check_result: $check_result"
if test -z "$check_result"; then
exit 0
else
echo "The cpp files are not formatted, please use internal/core/run_clang_format.sh"
exit 1
fi