admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-06 17:18:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fix load config parsing using wrong parameters for dynamic replica (#44430)

Browse Source 
issue: #44429
Fix the issue where dynamic modification of collection replica count
doesn't take effect due to incorrect parameter usage in load config
parsing.

Changes include:
- Replace DatabaseLevelReplicaNumber with CollectionLevelReplicaNumber
- Replace DatabaseLevelResourceGroups with CollectionLevelResourceGroups
- Update test cases to use correct collection-level constants
- Ensure dynamic replica changes are properly applied to collections

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
This commit is contained in:
wei liu 2025-09-22 10:42:02 +08:00 committed by GitHub
parent 94d53a5ac6
commit 3715ddcc81
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/rootcoord/alter_collection_task.go
View File

@ -186,10 +186,10 @@ func executeAlterCollectionTaskSteps(ctx context.Context,
opts: []proxyutil.ExpireCacheOpt{proxyutil.SetMsgType(commonpb.MsgType_AlterCollection)},
})
oldReplicaNumber, _ := common.DatabaseLevelReplicaNumber(oldColl.Properties)
oldResourceGroups, _ := common.DatabaseLevelResourceGroups(oldColl.Properties)
newReplicaNumber, _ := common.DatabaseLevelReplicaNumber(newColl.Properties)
newResourceGroups, _ := common.DatabaseLevelResourceGroups(newColl.Properties)
oldReplicaNumber, _ := common.CollectionLevelReplicaNumber(oldColl.Properties)
oldResourceGroups, _ := common.CollectionLevelResourceGroups(oldColl.Properties)
newReplicaNumber, _ := common.CollectionLevelReplicaNumber(newColl.Properties)
newResourceGroups, _ := common.CollectionLevelResourceGroups(newColl.Properties)
left, right := lo.Difference(oldResourceGroups, newResourceGroups)
rgChanged := len(left) > 0 || len(right) > 0
replicaChanged := oldReplicaNumber != newReplicaNumber

8
tests/integration/replicas/load/load_test.go
View File

@ -191,11 +191,11 @@ func (s *LoadTestSuite) TestLoadWithPredefineCollectionLevelConfig() {
CollectionName: collectionName,
Properties: []*commonpb.KeyValuePair{
{
Key: common.DatabaseReplicaNumber,
Key: common.CollectionReplicaNumber,
Value: "5",
},
{
Key: common.DatabaseResourceGroups,
Key: common.CollectionResourceGroups,
Value: strings.Join(rgs, ","),
},
},
@ -216,11 +216,11 @@ func (s *LoadTestSuite) TestLoadWithPredefineCollectionLevelConfig() {
CollectionName: collectionName,
Properties: []*commonpb.KeyValuePair{
{
Key: common.DatabaseReplicaNumber,
Key: common.CollectionReplicaNumber,
Value: "2",
},
{
Key: common.DatabaseResourceGroups,
Key: common.CollectionResourceGroups,
Value: strings.Join(rgs[:2], ","),
},
},