admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-07 01:28:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: [GoSDK] Use varchar when row field type is string (#33749)

Browse Source 
See also #33457

Also add `max_length` tag for specify varchar field max length attribute
from tagging

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2024-06-11 23:39:55 +08:00 committed by GitHub
parent 64f673cb4e
commit 323f8982ec
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
client/row/data.go
View File

@ -53,6 +53,9 @@ const (
// MilvusAutoID struct tag const for auto id indicator // MilvusAutoID struct tag const for auto id indicator
MilvusAutoID = `AUTO_ID` MilvusAutoID = `AUTO_ID`
// MilvusMaxLength struct tag const for max length
MilvusMaxLength = `MAX_LENGTH`
// DimMax dimension max value // DimMax dimension max value
DimMax = 65535 DimMax = 65535
) )
@ -116,7 +119,7 @@ func AnyToColumns(rows []interface{}, schemas ...*entity.Schema) ([]column.Colum
nameColumns[field.Name] = col nameColumns[field.Name] = col
case entity.FieldTypeString, entity.FieldTypeVarChar: case entity.FieldTypeString, entity.FieldTypeVarChar:
data := make([]string, 0, rowsLen) data := make([]string, 0, rowsLen)
col := column.NewColumnString(field.Name, data) col := column.NewColumnVarChar(field.Name, data)
nameColumns[field.Name] = col nameColumns[field.Name] = col
case entity.FieldTypeJSON: case entity.FieldTypeJSON:
data := make([][]byte, 0, rowsLen) data := make([][]byte, 0, rowsLen)

9
client/row/schema.go
View File

@ -99,7 +99,14 @@ func ParseSchema(r interface{}) (*entity.Schema, error) {
case reflect.Float64: case reflect.Float64:
field.DataType = entity.FieldTypeDouble field.DataType = entity.FieldTypeDouble
case reflect.String: case reflect.String:
field.DataType = entity.FieldTypeString field.DataType = entity.FieldTypeVarChar
if maxLengthVal, has := tagSettings[MilvusMaxLength]; has {
maxLength, err := strconv.ParseInt(maxLengthVal, 10, 64)
if err != nil {
return nil, fmt.Errorf("max length value %s is not valued", maxLengthVal)
}
field.WithMaxLength(maxLength)
}
case reflect.Array: case reflect.Array:
arrayLen := ft.Len() arrayLen := ft.Len()
elemType := ft.Elem() elemType := ft.Elem()