diff --git a/.github/workflows/automerge.yml b/.github/workflows/automerge.yml deleted file mode 100644 index 24f54624e8..0000000000 --- a/.github/workflows/automerge.yml +++ /dev/null @@ -1,27 +0,0 @@ -name: Automerge -on: - pull_request: - types: - - labeled - - unlabeled - - synchronize - - opened - - edited - - ready_for_review - - reopened - - unlocked - pull_request_review: - types: - - submitted - status: {} -jobs: - automerge: - runs-on: ubuntu-latest - steps: - - name: automerge - uses: "pascalgn/automerge-action@629929da409181990e4e638dcf84a74e11d3af66" - env: - GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" - MERGE_LABELS: "automerge,!work in progress" - MERGE_METHOD: "squash" - MERGE_COMMIT_MESSAGE: "pull-request-title" \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index 5a979d5c83..b01a938aa5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -701,7 +701,7 @@ Please mark all change in change log and use the issue from GitHub - MS-34 Fix prometheus-cpp thirdparty - MS-67 Fix license check bug - MS-76 Fix pipeline crash bug -- MS-100 cmake: fix AWS build issue +- MS-100 CMake: fix AWS build issue - MS-101 Change AWS build type to Release ## Improvement diff --git a/core/build.sh b/core/build.sh index 126fcc224a..4374f7bd78 100755 --- a/core/build.sh +++ b/core/build.sh @@ -154,11 +154,6 @@ if [[ ${RUN_CPPLINT} == "ON" ]]; then # echo "clang-tidy check passed!" else - # strip binary symbol - if [[ ${BUILD_TYPE} != "Debug" ]]; then - strip src/milvus_server - fi - # compile and build make -j 8 install || exit 1 fi diff --git a/core/src/main.cpp b/core/src/main.cpp index 559b67c618..e3483651de 100644 --- a/core/src/main.cpp +++ b/core/src/main.cpp @@ -77,7 +77,6 @@ main(int argc, char* argv[]) { std::string app_name = argv[0]; milvus::server::Server& server = milvus::server::Server::GetInstance(); - milvus::Status s; if (argc < 2) { print_help(app_name); @@ -133,8 +132,7 @@ main(int argc, char* argv[]) { server.Init(start_daemonized, pid_filename, config_filename, log_config_file); - s = server.Start(); - if (s.ok()) { + if (server.Start().ok()) { std::cout << "Milvus server started successfully!" << std::endl; } else { goto FAIL; diff --git a/core/src/server/grpc_impl/GrpcRequestHandler.cpp b/core/src/server/grpc_impl/GrpcRequestHandler.cpp index 4f128bcfbb..933886dddb 100644 --- a/core/src/server/grpc_impl/GrpcRequestHandler.cpp +++ b/core/src/server/grpc_impl/GrpcRequestHandler.cpp @@ -292,7 +292,7 @@ GrpcRequestHandler::OnPreSendMessage(::grpc::experimental::ServerRpcInfo* server context_map_.erase(request_id); } -const std::shared_ptr& +std::shared_ptr GrpcRequestHandler::GetContext(::grpc::ServerContext* server_context) { std::lock_guard lock(context_map_mutex_); auto request_id = get_request_id(server_context); diff --git a/core/src/server/grpc_impl/GrpcRequestHandler.h b/core/src/server/grpc_impl/GrpcRequestHandler.h index 735ec86231..af25fda5b2 100644 --- a/core/src/server/grpc_impl/GrpcRequestHandler.h +++ b/core/src/server/grpc_impl/GrpcRequestHandler.h @@ -71,7 +71,7 @@ class GrpcRequestHandler final : public ::milvus::grpc::MilvusService::Service, OnPreSendMessage(::grpc::experimental::ServerRpcInfo* server_rpc_info, ::grpc::experimental::InterceptorBatchMethods* interceptor_batch_methods) override; - const std::shared_ptr& + std::shared_ptr GetContext(::grpc::ServerContext* server_context); void diff --git a/sdk/build.sh b/sdk/build.sh index d909fe4fab..f078d98493 100755 --- a/sdk/build.sh +++ b/sdk/build.sh @@ -84,12 +84,6 @@ if [[ ${RUN_CPPLINT} == "ON" ]]; then # fi # echo "clang-tidy check passed!" else - - # strip binary symbol - if [[ ${BUILD_TYPE} != "Debug" ]]; then - strip src/milvus_server - fi - # compile and build make -j 8 || exit 1 fi