admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

avoid insert hangs (#3841)

Browse Source 
Signed-off-by: groot <yihua.mo@zilliz.com>
This commit is contained in:
groot 2020-09-22 19:35:18 +08:00 committed by GitHub
parent 30f4ba3ce8
commit 30e3420677
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
core/src/db/insert/MemCollection.cpp
View File

@ -141,14 +141,9 @@ MemCollection::Serialize() {
recorder.RecordSection("ApplyDeleteToFile");
// serialize mem to new segment files
while (true) {
auto status = SerializeSegments();
if (status.ok()) {
break;
} else if (status.code() == SS_STALE_ERROR) {
LOG_ENGINE_ERROR_ << "Failed to serialize segments: something stale. Try again";
continue;
}
auto status = SerializeSegments();
if (!status.ok()) {
LOG_ENGINE_ERROR_ << "Failed to serialize segments: " << status.message();
}
recorder.RecordSection("SerializeSegments");
@ -352,12 +347,21 @@ MemCollection::SerializeSegments() {
idx_t max_op_id = 0;
for (auto& partition_segments : mem_segments_) {
MemSegmentList& segments = partition_segments.second;
for (auto& segment : segments) {
STATUS_CHECK(segment->Serialize(ss, operation));
for (MemSegmentList::iterator iter = segments.begin(); iter != segments.end();) {
auto& segment = *iter;
auto status = segment->Serialize(ss, operation);
idx_t segment_max_op_id = segment->GetMaxOpID();
if (max_op_id < segment_max_op_id) {
max_op_id = segment_max_op_id;
}
// if the partition or collection has been deleted, the Serialize method will failed
// that means no need to serialize this segment, remove it from segment list
if (status.ok()) {
++iter;
} else {
iter = segments.erase(iter);
}
}
}
operation->SetContextLsn(max_op_id);