admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-08 01:58:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add more specific comment in datanode (#9488)

Browse Source 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
This commit is contained in:
XuanYang-cn 2021-10-09 00:09:47 +08:00 committed by GitHub
parent 97a6bde82a
commit 30395cb1b1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gitignore vendored
View File

@ -72,6 +72,7 @@ gtags.conf
*coverage.txt *coverage.txt
profile.out profile.out
*coverage.html *coverage.html
cover.out
# codecov-cpp generated files # codecov-cpp generated files
lcov_*.info lcov_*.info

3
internal/datanode/data_node.go
View File

@ -415,6 +415,7 @@ func (node *DataNode) WatchDmChannels(ctx context.Context, in *datapb.WatchDmCha
default: default:
for _, chanInfo := range in.GetVchannels() { for _, chanInfo := range in.GetVchannels() {
log.Info("DataNode new dataSyncService", log.Info("DataNode new dataSyncService",
zap.Int64("collectionID", chanInfo.GetCollectionID()),
zap.String("channel name", chanInfo.ChannelName), zap.String("channel name", chanInfo.ChannelName),
zap.Any("channal Info", chanInfo), zap.Any("channal Info", chanInfo),
) )
@ -422,7 +423,9 @@ func (node *DataNode) WatchDmChannels(ctx context.Context, in *datapb.WatchDmCha
log.Warn("Failed to new data sync service", log.Warn("Failed to new data sync service",
zap.Any("channel", chanInfo), zap.Any("channel", chanInfo),
zap.Error(err)) zap.Error(err))
// return error even partial success // return error even partial success
// TODO Goose: release partial success resources?
status.Reason = err.Error() status.Reason = err.Error()
return status, nil return status, nil
} }