diff --git a/.gitignore b/.gitignore index c5b93bad56..48fe6b63fe 100644 --- a/.gitignore +++ b/.gitignore @@ -72,6 +72,7 @@ gtags.conf *coverage.txt profile.out *coverage.html +cover.out # codecov-cpp generated files lcov_*.info diff --git a/internal/datanode/data_node.go b/internal/datanode/data_node.go index 7f39337e3c..6fdac99049 100644 --- a/internal/datanode/data_node.go +++ b/internal/datanode/data_node.go @@ -415,6 +415,7 @@ func (node *DataNode) WatchDmChannels(ctx context.Context, in *datapb.WatchDmCha default: for _, chanInfo := range in.GetVchannels() { log.Info("DataNode new dataSyncService", + zap.Int64("collectionID", chanInfo.GetCollectionID()), zap.String("channel name", chanInfo.ChannelName), zap.Any("channal Info", chanInfo), ) @@ -422,7 +423,9 @@ func (node *DataNode) WatchDmChannels(ctx context.Context, in *datapb.WatchDmCha log.Warn("Failed to new data sync service", zap.Any("channel", chanInfo), zap.Error(err)) + // return error even partial success + // TODO Goose: release partial success resources? status.Reason = err.Error() return status, nil }