From 2e8f018e40fb33ce841861fa5f9ba759bccbe5ab Mon Sep 17 00:00:00 2001 From: wxyu Date: Sat, 24 Aug 2019 16:42:15 +0800 Subject: [PATCH] MS-416 ExecutionEngineImpl::GpuCache has not return value cause crash Former-commit-id: 298969de85a0a8cb4a4e48da21d45fde30df64d1 --- cpp/CHANGELOG.md | 1 + cpp/src/db/engine/ExecutionEngineImpl.cpp | 2 ++ 2 files changed, 3 insertions(+) diff --git a/cpp/CHANGELOG.md b/cpp/CHANGELOG.md index e81e61d21a..ce3957e821 100644 --- a/cpp/CHANGELOG.md +++ b/cpp/CHANGELOG.md @@ -7,6 +7,7 @@ Please mark all change in change log and use the ticket from JIRA. ## Bug - MS-411 - Fix metric unittest linking error - MS-412 - Fix gpu cache logical error +- MS-416 - ExecutionEngineImpl::GpuCache has not return value cause crash ## Improvement - MS-327 - Clean code for milvus diff --git a/cpp/src/db/engine/ExecutionEngineImpl.cpp b/cpp/src/db/engine/ExecutionEngineImpl.cpp index 7489e7849e..7ae48649fb 100644 --- a/cpp/src/db/engine/ExecutionEngineImpl.cpp +++ b/cpp/src/db/engine/ExecutionEngineImpl.cpp @@ -273,6 +273,8 @@ Status ExecutionEngineImpl::Cache() { Status ExecutionEngineImpl::GpuCache(uint64_t gpu_id) { zilliz::milvus::cache::GpuCacheMgr::GetInstance(gpu_id)->InsertItem(location_, index_); + + return Status::OK(); } // TODO(linxj): remove.