admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-07 17:48:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: unexpected password for root user (#41817)

Browse Source 
issue: #41816 
pr #37983 introduced an issue, if doesn't specified
`defaultRootPassword` in milvus.yaml, then `"Milvus"` will be used as
default password for root user, instead of `Milvus`.

This PR fix the unexpected password for root, and add comment for case
which use large numeric password requires double quotes.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
This commit is contained in:
wei liu 2025-05-14 19:42:22 +08:00 committed by GitHub
parent c45c1fadb2
commit 2d0ae3a709
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
configs/milvus.yaml
View File

@ -875,7 +875,9 @@ common:
# The superusers will ignore some system check processes, # The superusers will ignore some system check processes,
# like the old password verification when updating the credential # like the old password verification when updating the credential
superUsers: superUsers:
defaultRootPassword: "Milvus" # default password for root user. The maximum length is 72 characters, and double quotes are required. # default password for root user. The maximum length is 72 characters.
# Large numeric passwords require double quotes to avoid yaml parsing precision issues.
defaultRootPassword: Milvus
rootShouldBindRole: false # Whether the root user should bind a role when the authorization is enabled. rootShouldBindRole: false # Whether the root user should bind a role when the authorization is enabled.
enablePublicPrivilege: true # Whether to enable public privilege enablePublicPrivilege: true # Whether to enable public privilege
rbac: rbac:

9
pkg/util/paramtable/component_param.go
View File

@ -675,10 +675,11 @@ like the old password verification when updating the credential`,
p.SuperUsers.Init(base.mgr) p.SuperUsers.Init(base.mgr)
p.DefaultRootPassword = ParamItem{ p.DefaultRootPassword = ParamItem{
Key: "common.security.defaultRootPassword", Key: "common.security.defaultRootPassword",
Version: "2.4.7", Version: "2.4.7",
Doc: "default password for root user. The maximum length is 72 characters, and double quotes are required.", Doc: `default password for root user. The maximum length is 72 characters.
DefaultValue: "\"Milvus\"", Large numeric passwords require double quotes to avoid yaml parsing precision issues.`,
DefaultValue: "Milvus",
Export: true, Export: true,
} }
p.DefaultRootPassword.Init(base.mgr) p.DefaultRootPassword.Init(base.mgr)