From f4629b242e6c0c930e6250888541990932e426b7 Mon Sep 17 00:00:00 2001 From: AllenYu1987 Date: Thu, 23 Apr 2020 10:42:54 +0800 Subject: [PATCH 1/2] Update GrpcRequestHandler.cpp: Use std::copy to replace forloop assignment Signed-off-by: AllenYu1987 --- core/src/server/grpc_impl/GrpcRequestHandler.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/core/src/server/grpc_impl/GrpcRequestHandler.cpp b/core/src/server/grpc_impl/GrpcRequestHandler.cpp index 076f23a140..5a0636b0d1 100644 --- a/core/src/server/grpc_impl/GrpcRequestHandler.cpp +++ b/core/src/server/grpc_impl/GrpcRequestHandler.cpp @@ -460,9 +460,7 @@ GrpcRequestHandler::Search(::grpc::ServerContext* context, const ::milvus::grpc: // step 2: partition tags std::vector partitions; - for (auto& partition : request->partition_tag_array()) { - partitions.emplace_back(partition); - } + std::copy(request->partition_tag_array().begin(), request->partition_tag_array().end(), std::back_inserter(partitions)); // step 3: parse extra parameters milvus::json json_params; From 7d63d15718425943594d3ca8edae541762097d0c Mon Sep 17 00:00:00 2001 From: JinHai-CN Date: Thu, 23 Apr 2020 10:53:33 +0800 Subject: [PATCH 2/2] Fix lint Signed-off-by: JinHai-CN --- core/src/server/grpc_impl/GrpcRequestHandler.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/src/server/grpc_impl/GrpcRequestHandler.cpp b/core/src/server/grpc_impl/GrpcRequestHandler.cpp index 5a0636b0d1..9dc1fbd3f6 100644 --- a/core/src/server/grpc_impl/GrpcRequestHandler.cpp +++ b/core/src/server/grpc_impl/GrpcRequestHandler.cpp @@ -12,6 +12,7 @@ #include "server/grpc_impl/GrpcRequestHandler.h" #include +#include #include #include #include @@ -460,7 +461,8 @@ GrpcRequestHandler::Search(::grpc::ServerContext* context, const ::milvus::grpc: // step 2: partition tags std::vector partitions; - std::copy(request->partition_tag_array().begin(), request->partition_tag_array().end(), std::back_inserter(partitions)); + std::copy(request->partition_tag_array().begin(), request->partition_tag_array().end(), + std::back_inserter(partitions)); // step 3: parse extra parameters milvus::json json_params;