From 28d39399e29ce3182fbc7e48f8caa58fb8802e33 Mon Sep 17 00:00:00 2001 From: "cai.zhang" Date: Tue, 3 Dec 2024 14:58:39 +0800 Subject: [PATCH] enhance: Refine clustering compaction log (#38100) Signed-off-by: Cai Zhang --- internal/datacoord/compaction_task_clustering.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/datacoord/compaction_task_clustering.go b/internal/datacoord/compaction_task_clustering.go index f663d091b7..fe0e37d1ab 100644 --- a/internal/datacoord/compaction_task_clustering.go +++ b/internal/datacoord/compaction_task_clustering.go @@ -247,6 +247,7 @@ func (t *clusteringCompactionTask) processExecuting() error { log := log.With(zap.Int64("planID", t.GetTaskProto().GetPlanID()), zap.String("type", t.GetTaskProto().GetType().String())) result, err := t.sessions.GetCompactionPlanResult(t.GetTaskProto().GetNodeID(), t.GetTaskProto().GetPlanID()) if err != nil || result == nil { + log.Warn("processExecuting clustering compaction", zap.Error(err)) if errors.Is(err, merr.ErrNodeNotFound) { log.Warn("GetCompactionPlanResult fail", zap.Error(err)) // setNodeID(NullNodeID) to trigger reassign node ID @@ -254,7 +255,8 @@ func (t *clusteringCompactionTask) processExecuting() error { } return err } - log.Info("compaction result", zap.Any("result", result.String())) + log.Debug("compaction result", zap.String("result state", result.GetState().String()), + zap.Int("result segments num", len(result.GetSegments())), zap.Int("result string length", len(result.String()))) switch result.GetState() { case datapb.CompactionTaskState_completed: t.result = result @@ -685,6 +687,7 @@ func (t *clusteringCompactionTask) updateAndSaveTaskMeta(opts ...compactionTaskO return merr.WrapErrClusteringCompactionMetaError("updateAndSaveTaskMeta", err) // retryable } t.SetTask(task) + log.Info("updateAndSaveTaskMeta success", zap.String("task state", t.GetTaskProto().GetState().String())) return nil }