From 1b7aeaffdfec1bc627f86827ac0264c2bd22b954 Mon Sep 17 00:00:00 2001
From: BossZou <40255591+BossZou@users.noreply.github.com>
Date: Tue, 12 May 2020 09:28:10 +0800
Subject: [PATCH] Fix server start failed when mode is 'read_only' (#2294)

* fix deploy bug

Signed-off-by: yhz <413554850@qq.com>

* fix unittest fail

Signed-off-by: yhz <413554850@qq.com>

* remove unused yml

Signed-off-by: yhz <413554850@qq.com>

* change to readonly

Signed-off-by: yhz <413554850@qq.com>
---
 core/src/server/init/StorageChecker.cpp | 10 ++++++++++
 core/unittest/server/test_web.cpp       |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/core/src/server/init/StorageChecker.cpp b/core/src/server/init/StorageChecker.cpp
index 30be2ca3e6..5f398f8af6 100644
--- a/core/src/server/init/StorageChecker.cpp
+++ b/core/src/server/init/StorageChecker.cpp
@@ -44,6 +44,16 @@ StorageChecker::CheckStoragePermission() {
         return Status(SERVER_UNEXPECTED_ERROR, err_msg);
     }
 
+    std::string deploy_mode;
+    status = config.GetServerConfigDeployMode(deploy_mode);
+    if (!status.ok()) {
+        return status;
+    }
+
+    if (deploy_mode == "cluster_readonly") {
+        return Status::OK();
+    }
+
     /* Check db directory write permission */
     std::string primary_path;
     status = config.GetStorageConfigPrimaryPath(primary_path);
diff --git a/core/unittest/server/test_web.cpp b/core/unittest/server/test_web.cpp
index 02e0e38b98..0bbc2f46e7 100644
--- a/core/unittest/server/test_web.cpp
+++ b/core/unittest/server/test_web.cpp
@@ -139,7 +139,7 @@ namespace {
 static const char* CONTROLLER_TEST_VALID_CONFIG_STR =
     "# Default values are used when you make no changes to the following parameters.\n"
     "\n"
-    "version: 0.1\n"
+    "version: 0.4\n"
     "\n"
     "#----------------------+------------------------------------------------------------+------------+----------------"
     "-+\n"