From 1af2ee903c160b14ff21654965ea28370f623bbe Mon Sep 17 00:00:00 2001 From: congqixia Date: Wed, 3 Apr 2024 11:29:14 +0800 Subject: [PATCH] fix: Check parse QueryInfo error before using it (#31836) See also milvus-io/milvus-sdk-go#693 #31735 Signed-off-by: Congqi Xia --- internal/proxy/search_util.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/proxy/search_util.go b/internal/proxy/search_util.go index fb0320507d..9a25ea4c3f 100644 --- a/internal/proxy/search_util.go +++ b/internal/proxy/search_util.go @@ -77,6 +77,9 @@ func initSearchRequest(ctx context.Context, t *searchTask, isHybrid bool) error annsFieldName = vecFields[0].Name } queryInfo, offset, err := parseSearchInfo(t.request.GetSearchParams(), t.schema.CollectionSchema) + if err != nil { + return err + } annField := typeutil.GetFieldByName(t.schema.CollectionSchema, annsFieldName) if queryInfo.GetGroupByFieldId() != -1 && isHybrid { return errors.New("not support search_group_by operation in the hybrid search") @@ -85,9 +88,6 @@ func initSearchRequest(ctx context.Context, t *searchTask, isHybrid bool) error return errors.New("not support search_group_by operation based on binary vector column") } - if err != nil { - return err - } t.offset = offset plan, err := planparserv2.CreateSearchPlan(t.schema.schemaHelper, t.request.Dsl, annsFieldName, queryInfo)