From 19164ea75320b8ec34993622628eaefcb30f3ab7 Mon Sep 17 00:00:00 2001 From: "yihao.dai" Date: Wed, 31 May 2023 16:45:29 +0800 Subject: [PATCH] Make binlog size metric to collect healthy binlog only (#24557) Signed-off-by: bigsheeper --- internal/datacoord/meta.go | 4 ++-- pkg/metrics/datacoord_metrics.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/datacoord/meta.go b/internal/datacoord/meta.go index e691853b91..2a460574b4 100644 --- a/internal/datacoord/meta.go +++ b/internal/datacoord/meta.go @@ -264,9 +264,9 @@ func (m *meta) GetCollectionBinlogSize() (int64, map[UniqueID]int64) { if isSegmentHealthy(segment) { total += segmentSize collectionBinlogSize[segment.GetCollectionID()] += segmentSize + metrics.DataCoordStoredBinlogSize.WithLabelValues( + fmt.Sprint(segment.GetCollectionID()), fmt.Sprint(segment.GetID())).Set(float64(segmentSize)) } - metrics.DataCoordStoredBinlogSize.WithLabelValues( - fmt.Sprint(segment.GetCollectionID()), fmt.Sprint(segment.GetID())).Set(float64(segmentSize)) } return total, collectionBinlogSize } diff --git a/pkg/metrics/datacoord_metrics.go b/pkg/metrics/datacoord_metrics.go index f6efae92ac..4496048c46 100644 --- a/pkg/metrics/datacoord_metrics.go +++ b/pkg/metrics/datacoord_metrics.go @@ -95,7 +95,7 @@ var ( Namespace: milvusNamespace, Subsystem: typeutil.DataCoordRole, Name: "stored_binlog_size", - Help: "binlog size of segments", + Help: "binlog size of healthy segments", }, []string{ collectionIDLabelName, segmentIDLabelName,