admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-06 17:18:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fix load segment failed due to get disk usage error (#45255)

Browse Source 
When getting disk usage, files or directories may be removed
concurrently due to segment release. This PR ignores “file or directory
does not exist” errors in such cases.

issue: https://github.com/milvus-io/milvus/issues/45239

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
This commit is contained in:
yihao.dai 2025-11-06 08:51:33 +08:00 committed by GitHub
parent 55bfd610b6
commit 121eb912ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 46 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
internal/core/src/storage/LocalChunkManager.cpp
View File

@ -234,37 +234,61 @@ LocalChunkManager::RemoveDir(const std::string& dir) {
} }
} }
// GetSizeOfDir is used to get the size of a directory, it will recursively
// get the size of all files and subdirectories in the directory.
// If file/directory doesn't exist, ignore it because it may be removed concurrently;
int64_t int64_t
LocalChunkManager::GetSizeOfDir(const std::string& dir) { LocalChunkManager::GetSizeOfDir(const std::string& dir) {
boost::filesystem::path dirPath(dir); boost::filesystem::path dirPath(dir);
bool is_dir = boost::filesystem::is_directory(dirPath); boost::system::error_code it_ec;
if (!is_dir) { boost::filesystem::directory_iterator it(dirPath, it_ec);
ThrowInfo(PathNotExist, "dir:" + dir + " not exists"); if (it_ec) {
if (it_ec.value() == boost::system::errc::no_such_file_or_directory) {
return 0;
}
ThrowInfo(FileReadFailed,
fmt::format("iterate directory {} failed, error: {}",
dir,
it_ec.message()));
} }
using boost::filesystem::directory_entry;
using boost::filesystem::directory_iterator;
std::vector<directory_entry> v;
copy(directory_iterator(dirPath), directory_iterator(), back_inserter(v));
int64_t total_file_size = 0; int64_t total_file_size = 0;
for (std::vector<directory_entry>::const_iterator it = v.begin(); boost::filesystem::directory_iterator end_it;
it != v.end(); for (; it != end_it; ++it) {
++it) { boost::system::error_code status_ec;
if (boost::filesystem::is_regular_file(it->path())) { auto status = it->status(status_ec);
boost::system::error_code ec; if (status_ec) {
auto file_size = boost::filesystem::file_size(it->path(), ec); if (status_ec.value() ==
if (ec) { boost::system::errc::no_such_file_or_directory) {
// The file may be removed concurrently by other threads.
// So the file size cannot be obtained, just ignore it.
LOG_INFO("size of file {} cannot be obtained with error: {}",
it->path().string(),
ec.message());
continue; continue;
} }
total_file_size += file_size; ThrowInfo(FileReadFailed,
fmt::format("get status of {} failed, error: {}",
it->path().string(),
status_ec.message()));
} }
if (boost::filesystem::is_directory(it->path())) {
// Check if current entry is a regular file
if (boost::filesystem::is_regular_file(status)) {
boost::system::error_code file_size_ec;
auto file_size =
boost::filesystem::file_size(it->path(), file_size_ec);
if (file_size_ec) {
if (file_size_ec.value() ==
boost::system::errc::no_such_file_or_directory) {
continue;
}
ThrowInfo(FileReadFailed,
fmt::format("get size of file {} failed, error: {}",
it->path().string(),
file_size_ec.message()));
}
total_file_size += file_size;
continue;
}
// Check if current entry is a subdirectory
if (boost::filesystem::is_directory(status)) {
total_file_size += GetSizeOfDir(it->path().string()); total_file_size += GetSizeOfDir(it->path().string());
} }
} }