admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-07 09:38:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: groupby bug for ut (#30272)

Browse Source 
related: #29965

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
This commit is contained in:
MrPresent-Han 2024-01-25 20:57:00 +08:00 committed by GitHub
parent c02fb64ad6
commit 116d0f20b8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/core/src/query/GroupByOperator.cpp
View File

@ -168,7 +168,7 @@ GroupIteratorResult(
auto dis_closer = [&](float l, float r) { auto dis_closer = [&](float l, float r) {
if (PositivelyRelated(metrics_type)) if (PositivelyRelated(metrics_type))
return l > r; return l > r;
return l <= r; return l < r;
}; };
while (iterator->HasNext() && groupMap.size() < topK) { while (iterator->HasNext() && groupMap.size() < topK) {
auto [offset, dis] = iterator->Next(); auto [offset, dis] = iterator->Next();
@ -191,8 +191,8 @@ GroupIteratorResult(
//4. save groupBy results //4. save groupBy results
group_by_values.reserve(sortedGroupVals.size()); group_by_values.reserve(sortedGroupVals.size());
offsets.push_back(sortedGroupVals.size()); offsets.reserve(sortedGroupVals.size());
distances.push_back(sortedGroupVals.size()); distances.reserve(sortedGroupVals.size());
for (auto iter = sortedGroupVals.cbegin(); iter != sortedGroupVals.cend(); for (auto iter = sortedGroupVals.cbegin(); iter != sortedGroupVals.cend();
iter++) { iter++) {
group_by_values.emplace_back(iter->first); group_by_values.emplace_back(iter->first);