From 10bb2431d8b4facc30324b7e49cfbf649af6be9d Mon Sep 17 00:00:00 2001 From: Bingyi Sun Date: Tue, 5 Dec 2023 10:56:33 +0800 Subject: [PATCH] test: add checker unittests (#28954) issue: https://github.com/milvus-io/milvus/issues/28610 Signed-off-by: sunby --- .../querycoord/client/client_test.go | 9 +++++++ .../distributed/querycoord/service_test.go | 24 +++++++++++++++++++ .../checkers/controller_base_test.go | 5 ++++ 3 files changed, 38 insertions(+) diff --git a/internal/distributed/querycoord/client/client_test.go b/internal/distributed/querycoord/client/client_test.go index f2b94ca599..7fbdc62eab 100644 --- a/internal/distributed/querycoord/client/client_test.go +++ b/internal/distributed/querycoord/client/client_test.go @@ -149,6 +149,15 @@ func Test_NewClient(t *testing.T) { r27, err := client.DescribeResourceGroup(ctx, nil) retCheck(retNotNil, r27, err) + + r28, err := client.ListCheckers(ctx, nil) + retCheck(retNotNil, r28, err) + + r29, err := client.ActivateChecker(ctx, nil) + retCheck(retNotNil, r29, err) + + r30, err := client.DeactivateChecker(ctx, nil) + retCheck(retNotNil, r30, err) } client.grpcClient = &mock.GRPCClientBase[querypb.QueryCoordClient]{ diff --git a/internal/distributed/querycoord/service_test.go b/internal/distributed/querycoord/service_test.go index 359cd74fa5..5ad2ea0805 100644 --- a/internal/distributed/querycoord/service_test.go +++ b/internal/distributed/querycoord/service_test.go @@ -293,6 +293,30 @@ func Test_NewServer(t *testing.T) { assert.Equal(t, commonpb.ErrorCode_Success, resp.GetStatus().GetErrorCode()) }) + t.Run("ListCheckers", func(t *testing.T) { + req := &querypb.ListCheckersRequest{} + mqc.EXPECT().ListCheckers(mock.Anything, req).Return(&querypb.ListCheckersResponse{Status: successStatus}, nil) + resp, err := server.ListCheckers(ctx, req) + assert.NoError(t, err) + assert.Equal(t, commonpb.ErrorCode_Success, resp.GetStatus().GetErrorCode()) + }) + + t.Run("ActivateChecker", func(t *testing.T) { + req := &querypb.ActivateCheckerRequest{} + mqc.EXPECT().ActivateChecker(mock.Anything, req).Return(&commonpb.Status{ErrorCode: commonpb.ErrorCode_Success}, nil) + resp, err := server.ActivateChecker(ctx, req) + assert.NoError(t, err) + assert.Equal(t, commonpb.ErrorCode_Success, resp.ErrorCode) + }) + + t.Run("DeactivateChecker", func(t *testing.T) { + req := &querypb.DeactivateCheckerRequest{} + mqc.EXPECT().DeactivateChecker(mock.Anything, req).Return(&commonpb.Status{ErrorCode: commonpb.ErrorCode_Success}, nil) + resp, err := server.DeactivateChecker(ctx, req) + assert.NoError(t, err) + assert.Equal(t, commonpb.ErrorCode_Success, resp.ErrorCode) + }) + err = server.Stop() assert.NoError(t, err) } diff --git a/internal/querycoordv2/checkers/controller_base_test.go b/internal/querycoordv2/checkers/controller_base_test.go index 9c56c7481d..cfb1e202ef 100644 --- a/internal/querycoordv2/checkers/controller_base_test.go +++ b/internal/querycoordv2/checkers/controller_base_test.go @@ -99,6 +99,11 @@ func (s *ControllerBaseTestSuite) TestActivation() { s.Equal(errTypeNotFound, err) } +func (s *ControllerBaseTestSuite) TestListCheckers() { + checkers := s.controller.Checkers() + s.Equal(4, len(checkers)) +} + func TestControllerBaseTestSuite(t *testing.T) { suite.Run(t, new(ControllerBaseTestSuite)) }