admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-08 01:58:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: close timetick protection by default (#43650)

Browse Source 
issue: #43266

Signed-off-by: chyezh <chyezh@outlook.com>
This commit is contained in:
Zhen Ye 2025-07-30 19:51:37 +08:00 committed by GitHub
parent 6a74a7de66
commit 0d5e0ca795
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
configs/milvus.yaml
View File

@ -1143,7 +1143,7 @@ quotaAndLimits:
# specific conditions, such as memory of nodes to water marker), true means always reject all dml requests. # specific conditions, such as memory of nodes to water marker), true means always reject all dml requests.
forceDeny: false forceDeny: false
ttProtection: ttProtection:
enabled: true enabled: false
# maxTimeTickDelay indicates the backpressure for DML Operations. # maxTimeTickDelay indicates the backpressure for DML Operations.
# DML rates would be reduced according to the ratio of time tick delay to maxTimeTickDelay, # DML rates would be reduced according to the ratio of time tick delay to maxTimeTickDelay,
# if time tick delay is greater than maxTimeTickDelay, all DML requests would be rejected. # if time tick delay is greater than maxTimeTickDelay, all DML requests would be rejected.

2
pkg/util/paramtable/quota_param.go
View File

@ -1684,7 +1684,7 @@ specific conditions, such as memory of nodes to water marker), ` + "true" + ` me
p.TtProtectionEnabled = ParamItem{ p.TtProtectionEnabled = ParamItem{
Key: "quotaAndLimits.limitWriting.ttProtection.enabled", Key: "quotaAndLimits.limitWriting.ttProtection.enabled",
Version: "2.2.0", Version: "2.2.0",
DefaultValue: "true", DefaultValue: "false",
Export: true, Export: true,
} }
p.TtProtectionEnabled.Init(base.mgr) p.TtProtectionEnabled.Init(base.mgr)

2
pkg/util/paramtable/quota_param_test.go
View File

@ -206,7 +206,7 @@ func TestQuotaParam(t *testing.T) {
t.Run("test limit writing", func(t *testing.T) { t.Run("test limit writing", func(t *testing.T) {
assert.False(t, qc.ForceDenyWriting.GetAsBool()) assert.False(t, qc.ForceDenyWriting.GetAsBool())
assert.Equal(t, true, qc.TtProtectionEnabled.GetAsBool()) assert.Equal(t, false, qc.TtProtectionEnabled.GetAsBool())
assert.Equal(t, 1200, qc.MaxTimeTickDelay.GetAsInt()) assert.Equal(t, 1200, qc.MaxTimeTickDelay.GetAsInt())
assert.Equal(t, defaultLowWaterLevel, qc.DataNodeMemoryLowWaterLevel.GetAsFloat()) assert.Equal(t, defaultLowWaterLevel, qc.DataNodeMemoryLowWaterLevel.GetAsFloat())
assert.Equal(t, defaultHighWaterLevel, qc.DataNodeMemoryHighWaterLevel.GetAsFloat()) assert.Equal(t, defaultHighWaterLevel, qc.DataNodeMemoryHighWaterLevel.GetAsFloat())