admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: BM25 with boost return result not ordered. (#44744)

Browse Source 
relate: https://github.com/milvus-io/milvus/issues/44758
Wrong code which should be `(result.seg_offsets_[i] >= 0 &&
result.seg_offsets_[j] < 0)`, but was `(result.seg_offsets_[j] >= 0 &&
result.seg_offsets_[j] < 0) ` now.
But because all placeholder which was offset -1, will fill with worst
distance value.
For IP, L2 or COSIN, it will be +inf or -inf. So sort distance was
enough.
But when use BM25, it will be NAN. Will case sort out of ordered.

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
This commit is contained in:
aoiasd 2025-10-11 17:17:58 +08:00 committed by GitHub
parent faaf215913
commit 09865a5da5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
internal/core/src/exec/operator/Utils.h
View File

@ -118,15 +118,17 @@ sort_search_result(milvus::SearchResult& result, bool large_is_better) {
if (large_is_better) {
std::sort(idx.begin(), idx.end(), [&](size_t i, size_t j) {
return result.distances_[i] > result.distances_[j] ||
(result.seg_offsets_[j] >= 0 &&
result.seg_offsets_[j] < 0);
if (result.seg_offsets_[j] < 0 || result.seg_offsets_[i] < 0) {
return result.seg_offsets_[i] >= 0;
}
return result.distances_[i] > result.distances_[j];
});
} else {
std::sort(idx.begin(), idx.end(), [&](size_t i, size_t j) {
return result.distances_[i] < result.distances_[j] ||
(result.seg_offsets_[j] >= 0 &&
result.seg_offsets_[j] < 0);
if (result.seg_offsets_[j] < 0 || result.seg_offsets_[i] < 0) {
return result.seg_offsets_[i] >= 0;
}
return result.distances_[i] < result.distances_[j];
});
}
for (auto i : idx) {