From 249d7942cccb0cf66e08dba35a1d635feb69c78f Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 10:32:16 +0800 Subject: [PATCH 01/13] Update README.md Former-commit-id: e148a2c16f0f7a4ad9a2e9e50f654fbb5796ef5b --- README.md | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 1053ec4391..62bc0447e1 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,13 @@ ![Milvuslogo](https://milvus.io/docs/assets/milvus_logo.png) +![LICENSE](https://img.shields.io/badge/license-Apache--2.0-brightgreen) +![Language](https://img.shields.io/badge/language-C%2B%2B-blue) + - [Slack Community](https://join.slack.com/t/milvusio/shared_invite/enQtNzY1OTQ0NDI3NjMzLWNmYmM1NmNjOTQ5MGI5NDhhYmRhMGU5M2NhNzhhMDMzY2MzNDdlYjM5ODQ5MmE3ODFlYzU3YjJkNmVlNDQ2ZTk) -- [Blog](https://www.milvus.io/blog/) - [Twitter](https://twitter.com/milvus_io) +- [Blog](https://www.milvus.io/blog/) +- [CSDN](https://zilliz.blog.csdn.net/) + # Welcome to Milvus @@ -174,11 +179,16 @@ $ python3 example.py $ ./sdk_simple ``` +#### Run Java example code +Make sure Java 8 or higher is already installed. + +Refer to [this link](https://github.com/milvus-io/milvus-sdk-java/tree/master/examples) for example code. + ## Contribution guidelines Contributions are welcomed and greatly appreciated. If you want to contribute to Milvus, please read our [contribution guidelines](CONTRIBUTING.md). This project adheres to the [code of conduct](CODE_OF_CONDUCT.md) of Milvus. By participating, you are expected to uphold this code. -We use [GitHub issues](https://github.com/milvus-io/milvus/issues/new) to track issues and bugs. For general questions and public discussions, please join our community. +We use [GitHub issues](https://github.com/milvus-io/milvus/issues/new/choose) to track issues and bugs. For general questions and public discussions, please join our community. ## Join the Milvus community @@ -194,9 +204,11 @@ Please read our [roadmap](https://milvus.io/docs/en/roadmap/) to learn about upc [Milvus docs](https://www.milvus.io/docs/en/userguide/install_milvus/) +[Milvus bootcamp](https://github.com/milvus-io/bootcamp) + [Milvus blog](https://www.milvus.io/blog/) -[Milvus CSDN](https://mp.csdn.net/mdeditor/100041006#) +[Milvus CSDN](https://zilliz.blog.csdn.net/) [Milvus roadmap](https://milvus.io/docs/en/roadmap/) From 339e8f4723a4175f652371e2b8659c20042978c5 Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 11:29:46 +0800 Subject: [PATCH 02/13] Update README.md Former-commit-id: c24987d3a9699fed409c0778dabd65ab309863e5 --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 62bc0447e1..ed9203546e 100644 --- a/README.md +++ b/README.md @@ -7,6 +7,7 @@ - [Twitter](https://twitter.com/milvus_io) - [Blog](https://www.milvus.io/blog/) - [CSDN](https://zilliz.blog.csdn.net/) +- 中文网站(https://www.milvus.io/zh-CN/) # Welcome to Milvus @@ -182,7 +183,7 @@ $ python3 example.py #### Run Java example code Make sure Java 8 or higher is already installed. -Refer to [this link](https://github.com/milvus-io/milvus-sdk-java/tree/master/examples) for example code. +Refer to [this link](https://github.com/milvus-io/milvus-sdk-java/tree/master/examples) for the example code. ## Contribution guidelines From e80fd403dc399f1680fcef0153bba5d3f09afb93 Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 11:30:23 +0800 Subject: [PATCH 03/13] Update README.md Former-commit-id: fd2a5ef310a4ebf75dc62c9797e464ea1687fbd5 --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ed9203546e..d2622816b7 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ - [Twitter](https://twitter.com/milvus_io) - [Blog](https://www.milvus.io/blog/) - [CSDN](https://zilliz.blog.csdn.net/) -- 中文网站(https://www.milvus.io/zh-CN/) +- [中文官网](https://www.milvus.io/zh-CN/) # Welcome to Milvus From e524bfb35c4ef9249003f83c6dbb77ae38562039 Mon Sep 17 00:00:00 2001 From: "yudong.cai" Date: Wed, 16 Oct 2019 11:57:11 +0800 Subject: [PATCH 04/13] change default gpu_cache_capacity to 4 Former-commit-id: d5a629cb39c58cc82696b6656fe67a1e3270a300 --- core/conf/server_config.template | 2 ++ core/src/server/Config.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/core/conf/server_config.template b/core/conf/server_config.template index 2f2f699e09..27c2b12cfe 100644 --- a/core/conf/server_config.template +++ b/core/conf/server_config.template @@ -30,6 +30,8 @@ metric_config: cache_config: cpu_cache_capacity: 16 # GB, CPU memory used for cache cpu_cache_threshold: 0.85 # percentage of data that will be kept when cache cleanup is triggered + gpu_cache_capacity: 4 # GB, GPU memory used for cache + gpu_cache_threshold: 0.85 # percentage of data that will be kept when cache cleanup is triggered cache_insert_data: false # whether to load inserted data into cache engine_config: diff --git a/core/src/server/Config.h b/core/src/server/Config.h index 9c754256a2..f40c9f2224 100644 --- a/core/src/server/Config.h +++ b/core/src/server/Config.h @@ -62,7 +62,7 @@ static const char* CONFIG_CACHE = "cache_config"; static const char* CONFIG_CACHE_CPU_CACHE_CAPACITY = "cpu_cache_capacity"; static const char* CONFIG_CACHE_CPU_CACHE_CAPACITY_DEFAULT = "16"; static const char* CONFIG_CACHE_GPU_CACHE_CAPACITY = "gpu_cache_capacity"; -static const char* CONFIG_CACHE_GPU_CACHE_CAPACITY_DEFAULT = "0"; +static const char* CONFIG_CACHE_GPU_CACHE_CAPACITY_DEFAULT = "4"; static const char* CONFIG_CACHE_CPU_CACHE_THRESHOLD = "cpu_mem_threshold"; static const char* CONFIG_CACHE_CPU_CACHE_THRESHOLD_DEFAULT = "0.85"; static const char* CONFIG_CACHE_GPU_CACHE_THRESHOLD = "gpu_mem_threshold"; From af956f337fc3a629ba8d620ec7fcd0e3cc11aa9b Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 14:25:24 +0800 Subject: [PATCH 05/13] Update README.md Former-commit-id: 69949ae305efa2033872e35f66b37e0a096dbe1e --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d2622816b7..5eec7f34cf 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ ![Language](https://img.shields.io/badge/language-C%2B%2B-blue) - [Slack Community](https://join.slack.com/t/milvusio/shared_invite/enQtNzY1OTQ0NDI3NjMzLWNmYmM1NmNjOTQ5MGI5NDhhYmRhMGU5M2NhNzhhMDMzY2MzNDdlYjM5ODQ5MmE3ODFlYzU3YjJkNmVlNDQ2ZTk) -- [Twitter](https://twitter.com/milvus_io) +- [Twitter](https://twitter.com/milvusio) - [Blog](https://www.milvus.io/blog/) - [CSDN](https://zilliz.blog.csdn.net/) - [中文官网](https://www.milvus.io/zh-CN/) From 7d8f7ac073a45788baa8351701bdb3b09f9f580a Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 14:27:51 +0800 Subject: [PATCH 06/13] Update README.md Former-commit-id: 2b5651fa86b09ac5200b14218c9ee567a8a97405 --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 5eec7f34cf..0f24955a59 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -![Milvuslogo](https://milvus.io/docs/assets/milvus_logo.png) +![Milvuslogo](https://milvus.io/docs/tree/branch-0.5.0/assets/milvus_logo.png) ![LICENSE](https://img.shields.io/badge/license-Apache--2.0-brightgreen) ![Language](https://img.shields.io/badge/language-C%2B%2B-blue) @@ -37,7 +37,7 @@ Keep up-to-date with newest releases and latest updates by reading Milvus [relea The data is stored and computed on a distributed architecture. This lets you scale data sizes up and down without redesigning the system. ## Architecture -![Milvus_arch](https://milvus.io/docs/assets/milvus_arch.png) +![Milvus_arch](https://milvus.io/docs/tree/branch-0.5.0/assets/milvus_arch.png) ## Get started From 24d3b14ba4741ef04e877c68772d77fef91b27f1 Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 14:29:25 +0800 Subject: [PATCH 07/13] Update README.md Former-commit-id: 1ed79b12556c70cb50db8c7ec36ec303cbd64d6a --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0f24955a59..5eec7f34cf 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -![Milvuslogo](https://milvus.io/docs/tree/branch-0.5.0/assets/milvus_logo.png) +![Milvuslogo](https://milvus.io/docs/assets/milvus_logo.png) ![LICENSE](https://img.shields.io/badge/license-Apache--2.0-brightgreen) ![Language](https://img.shields.io/badge/language-C%2B%2B-blue) @@ -37,7 +37,7 @@ Keep up-to-date with newest releases and latest updates by reading Milvus [relea The data is stored and computed on a distributed architecture. This lets you scale data sizes up and down without redesigning the system. ## Architecture -![Milvus_arch](https://milvus.io/docs/tree/branch-0.5.0/assets/milvus_arch.png) +![Milvus_arch](https://milvus.io/docs/assets/milvus_arch.png) ## Get started From 75cc77e66a15935ec89f063d2f31d60cb9128166 Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 15:08:11 +0800 Subject: [PATCH 08/13] Update README.md Former-commit-id: 9c15b47dcfc3e3d9ea60b86985127aba39b2f9fb --- README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/README.md b/README.md index 5eec7f34cf..aa6d3fbb70 100644 --- a/README.md +++ b/README.md @@ -18,8 +18,6 @@ Firstly, welcome, and thanks for your interest in [Milvus](https://milvus.io)! N Milvus is an open source vector search engine that supports similarity search of large-scale vectors. Built on optimized indexing algorithm, it is compatible with major AI/ML models. -Milvus was developed by ZILLIZ, a tech startup that intends to reinvent data science, with the purpose of providing enterprises with efficient and scalable similarity search and analysis of feature vectors and unstructured data. - Milvus provides stable Python, C++ and Java APIs. Keep up-to-date with newest releases and latest updates by reading Milvus [release notes](https://milvus.io/docs/en/Releases/v0.4.0/). From 9f138078c006fde9cb532462b6b3ebb1081b20c8 Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 15:27:10 +0800 Subject: [PATCH 09/13] Update README.md Former-commit-id: 212c3fe64bebab057feb08261529b952357aec56 --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index aa6d3fbb70..ce3cd77f37 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -![Milvuslogo](https://milvus.io/docs/assets/milvus_logo.png) +![Milvuslogo](https://github.com/milvus-io/docs/blob/branch-0.5.0/assets/milvus_logo.png) ![LICENSE](https://img.shields.io/badge/license-Apache--2.0-brightgreen) ![Language](https://img.shields.io/badge/language-C%2B%2B-blue) @@ -35,7 +35,7 @@ Keep up-to-date with newest releases and latest updates by reading Milvus [relea The data is stored and computed on a distributed architecture. This lets you scale data sizes up and down without redesigning the system. ## Architecture -![Milvus_arch](https://milvus.io/docs/assets/milvus_arch.png) +![Milvus_arch](https://github.com/milvus-io/docs/blob/branch-0.5.0/assets/milvus_arch.png) ## Get started From cb088c77782414a9b3a04b670da51628e3e20274 Mon Sep 17 00:00:00 2001 From: jielinxu Date: Wed, 16 Oct 2019 16:17:04 +0800 Subject: [PATCH 10/13] update README and CONTRIBUTING Former-commit-id: 4bf191eebdaa945ce58c5c31124f4837862960fe --- CONTRIBUTING.md | 56 ++++++++++++++++++++++++++++++++++++++++--------- README.md | 53 ++-------------------------------------------- 2 files changed, 48 insertions(+), 61 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 11068ca7e1..475387c319 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,6 @@ # Contributing to Milvus -First of all, thanks for taking the time to contribute to Milvus! It's people like you that help Milvus come to fruition. +First of all, thanks for taking the time to contribute to Milvus! It's people like you that help Milvus come to fruition. :tada: The following are a set of guidelines for contributing to Milvus. Following these guidelines helps contributing to this project easy and transparent. These are mostly guideline, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request. @@ -11,8 +11,8 @@ As for everything else in the project, the contributions to Milvus are governed Before you make any contributions, make sure you follow this list. - Read [Contributing to Milvus](CONTRIBUTING.md). -- Check if the changes are consistent with the [coding style](CONTRIBUTING.md#coding-style). -- Run [unit tests](CONTRIBUTING.md#run-unit-test). +- Check if the changes are consistent with the [coding style](CONTRIBUTING.md#coding-style), and format your code accordingly. +- Run [unit tests](CONTRIBUTING.md#run-unit-test-with-code-coverage) and check your code coverage rate. ## What contributions can I make? @@ -68,15 +68,51 @@ And we made the following changes based on the guide: - 120-character line length - Camel-Cased file names +### Format code -## Run unit test - -We use Google Test framework for test running. -To run unit test for Milvus under C++, please use the following command: - +Install clang-format ```shell -# Run unit test for Milvus -$ ./build.sh -u +$ sudo apt-get install clang-format +$ rm cmake_build/CMakeCache.txt +``` +Check code style +```shell +$ ./build.sh -l +``` +To format the code +```shell +$ cd cmake_build +$ make clang-format ``` +## Run unit test with code coverage + +Before submitting your PR, make sure you have run unit test, and your code coverage rate is >= 90%. + +Install lcov +```shell +$ sudo apt-get install lcov +``` +Run unit test and generate code for code coverage check +```shell +$ ./build.sh -u -c +``` + +Run MySQL docker +```shell +docker pull mysql:latest +docker run -p 3306:3306 -e MYSQL_ROOT_PASSWORD=123456 -d mysql:latest +``` + +Run code coverage + +```shell +$ ./coverage.sh -u root -p 123456 -t 127.0.0.1 +``` + +Or start your own MySQL server, and then run code coverage + +```shell +$ ./coverage.sh -u ${MYSQL_USERNAME} -p ${MYSQL_PASSWORD} -t ${MYSQL_SERVER_IP} +``` diff --git a/README.md b/README.md index ce3cd77f37..5ea44c3122 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ # Welcome to Milvus -Firstly, welcome, and thanks for your interest in [Milvus](https://milvus.io)! No matter who you are, what you do, we greatly appreciate your contribution to help us reinvent data science with Milvus. +Firstly, welcome, and thanks for your interest in [Milvus](https://milvus.io)! ​​No matter who you are, what you do, we greatly appreciate your contribution to help us reinvent data science with Milvus. ## What is Milvus @@ -28,7 +28,7 @@ Keep up-to-date with newest releases and latest updates by reading Milvus [relea - Intelligent index - With a “Decide Your Own Algorithm” approach, you can embed machine learning and advanced algorithms into Milvus without the headache of complex data engineering or migrating data between disparate systems. Milvus is built on optimized indexing algorithm based on quantization indexing, tree-based and graph indexing methods. + With a "Decide Your Own Algorithm" approach, you can embed machine learning and advanced algorithms into Milvus without the headache of complex data engineering or migrating data between disparate systems. Milvus is built on optimized indexing algorithm based on quantization indexing, tree-based and graph indexing methods. - Strong scalability @@ -72,55 +72,6 @@ $ ./build.sh -t Release When the build is completed, all the stuff that you need in order to run Milvus will be installed under `[Milvus root path]/core/milvus`. -#### Code format and linting - -Install clang-format -```shell -$ sudo apt-get install clang-format -$ rm cmake_build/CMakeCache.txt -``` -Check code style -```shell -$ ./build.sh -l -``` -To format the code -```shell -$ cd cmake_build -$ make clang-format -``` - -#### Run unit test - -```shell -$ ./build.sh -u -``` - -#### Run code coverage - -Install lcov -```shell -$ sudo apt-get install lcov -``` -```shell -$ ./build.sh -u -c -``` -Run MySQL docker -```shell -docker pull mysql:latest -docker run -p 3306:3306 -e MYSQL_ROOT_PASSWORD=123456 -d mysql:latest -``` -Run code coverage - -```shell -$ ./coverage.sh -u root -p 123456 -t 127.0.0.1 -``` - -Or start your own MySQL server, and then run code coverage - -```shell -$ ./coverage.sh -u ${MYSQL_USERNAME} -p ${MYSQL_PASSWORD} -t ${MYSQL_SERVER_IP} -``` - #### Launch Milvus server ```shell From 090e1ce15e4c4b1a32709a10b2853f9fa730bff7 Mon Sep 17 00:00:00 2001 From: starlord Date: Wed, 16 Oct 2019 16:34:43 +0800 Subject: [PATCH 11/13] change default db path to /tmp/milvus Former-commit-id: d161cc82ee46ac10460f3a7b8e85a8ac4f0fea46 --- ci/jenkinsfile/milvus_build.groovy | 2 +- ci/jenkinsfile/milvus_build_no_ut.groovy | 2 +- core/build.sh | 20 +++++++++++++------- 3 files changed, 15 insertions(+), 9 deletions(-) diff --git a/ci/jenkinsfile/milvus_build.groovy b/ci/jenkinsfile/milvus_build.groovy index 7b0da2116c..11f8c51d33 100644 --- a/ci/jenkinsfile/milvus_build.groovy +++ b/ci/jenkinsfile/milvus_build.groovy @@ -15,7 +15,7 @@ container('milvus-build-env') { && export JFROG_USER_NAME='${USERNAME}' \ && export JFROG_PASSWORD='${PASSWORD}' \ && export FAISS_URL='http://192.168.1.105:6060/jinhai/faiss/-/archive/branch-0.2.1/faiss-branch-0.2.1.tar.gz' \ - && ./build.sh -t ${params.BUILD_TYPE} -j -u -c" + && ./build.sh -t ${params.BUILD_TYPE} -d /opt/milvus -j -u -c" sh "./coverage.sh -u root -p 123456 -t 192.168.1.194" } diff --git a/ci/jenkinsfile/milvus_build_no_ut.groovy b/ci/jenkinsfile/milvus_build_no_ut.groovy index 24f2cedef4..1dd3361106 100644 --- a/ci/jenkinsfile/milvus_build_no_ut.groovy +++ b/ci/jenkinsfile/milvus_build_no_ut.groovy @@ -15,7 +15,7 @@ container('milvus-build-env') { && export JFROG_USER_NAME='${USERNAME}' \ && export JFROG_PASSWORD='${PASSWORD}' \ && export FAISS_URL='http://192.168.1.105:6060/jinhai/faiss/-/archive/branch-0.2.1/faiss-branch-0.2.1.tar.gz' \ - && ./build.sh -t ${params.BUILD_TYPE} -j" + && ./build.sh -t ${params.BUILD_TYPE} -j -d /opt/milvus" } } } catch (exc) { diff --git a/core/build.sh b/core/build.sh index c0bd9c5221..795c87c6bf 100755 --- a/core/build.sh +++ b/core/build.sh @@ -1,11 +1,12 @@ #!/bin/bash +BUILD_OUTPUT_DIR="cmake_build" BUILD_TYPE="Debug" BUILD_UNITTEST="OFF" INSTALL_PREFIX=$(pwd)/milvus MAKE_CLEAN="OFF" BUILD_COVERAGE="OFF" -DB_PATH="/opt/milvus" +DB_PATH="/tmp/milvus" PROFILING="OFF" USE_JFROG_CACHE="OFF" RUN_CPPLINT="OFF" @@ -40,8 +41,8 @@ do RUN_CPPLINT="ON" ;; r) - if [[ -d cmake_build ]]; then - rm ./cmake_build -r + if [[ -d ${BUILD_OUTPUT_DIR} ]]; then + rm ./${BUILD_OUTPUT_DIR} -r MAKE_CLEAN="ON" fi ;; @@ -62,7 +63,7 @@ do parameter: -p: install prefix(default: $(pwd)/milvus) --d: db path(default: /opt/milvus) +-d: db data path(default: /tmp/milvus) -t: build type(default: Debug) -u: building unit test options(default: OFF) -l: run cpplint, clang-format and clang-tidy(default: OFF) @@ -84,11 +85,11 @@ usage: esac done -if [[ ! -d cmake_build ]]; then - mkdir cmake_build +if [[ ! -d ${BUILD_OUTPUT_DIR} ]]; then + mkdir ${BUILD_OUTPUT_DIR} fi -cd cmake_build +cd ${BUILD_OUTPUT_DIR} CMAKE_CMD="cmake \ -DBUILD_UNIT_TEST=${BUILD_UNITTEST} \ @@ -114,6 +115,7 @@ if [[ ${RUN_CPPLINT} == "ON" ]]; then make lint if [ $? -ne 0 ]; then echo "ERROR! cpplint check failed" + rm -f CMakeCache.txt exit 1 fi echo "cpplint check passed!" @@ -122,6 +124,7 @@ if [[ ${RUN_CPPLINT} == "ON" ]]; then make check-clang-format if [ $? -ne 0 ]; then echo "ERROR! clang-format check failed" + rm -f CMakeCache.txt exit 1 fi echo "clang-format check passed!" @@ -130,9 +133,12 @@ if [[ ${RUN_CPPLINT} == "ON" ]]; then # make check-clang-tidy # if [ $? -ne 0 ]; then # echo "ERROR! clang-tidy check failed" +# rm -f CMakeCache.txt # exit 1 # fi # echo "clang-tidy check passed!" + + rm -f CMakeCache.txt else # compile and build make -j 4 || exit 1 From 311897202aca76973ebfa44b989fe63f92953001 Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 16:41:49 +0800 Subject: [PATCH 12/13] Update README.md Former-commit-id: 83fd278d294af5578941f7d1e4c8df180773035c --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5ea44c3122..4f57318c90 100644 --- a/README.md +++ b/README.md @@ -35,7 +35,7 @@ Keep up-to-date with newest releases and latest updates by reading Milvus [relea The data is stored and computed on a distributed architecture. This lets you scale data sizes up and down without redesigning the system. ## Architecture -![Milvus_arch](https://github.com/milvus-io/docs/blob/branch-0.5.0/assets/milvus_arch.png) +![Milvus_arch](https://github.com/milvus-io/docs/blob/branch-0.5.0/assets/milvus_arch.) ## Get started From 6ec58ac425444c9c9490fbc4619266387a480f26 Mon Sep 17 00:00:00 2001 From: jielinxu <52057195+jielinxu@users.noreply.github.com> Date: Wed, 16 Oct 2019 16:48:43 +0800 Subject: [PATCH 13/13] Update README.md Former-commit-id: c3c92b02c8ad05213dfff8af149cfbbeef2e5a7c --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4f57318c90..08760798e2 100644 --- a/README.md +++ b/README.md @@ -35,7 +35,7 @@ Keep up-to-date with newest releases and latest updates by reading Milvus [relea The data is stored and computed on a distributed architecture. This lets you scale data sizes up and down without redesigning the system. ## Architecture -![Milvus_arch](https://github.com/milvus-io/docs/blob/branch-0.5.0/assets/milvus_arch.) +![Milvus_arch](https://github.com/milvus-io/docs/blob/branch-0.5.0/assets/milvus_arch.jpg) ## Get started