admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: [skip e2e] Wait eventch in TestUpdateSessions (#44640)

Browse Source 
Related to #44620

Make unittest stable by waiting eventch instead of async read
len(eventCh), which is unstable

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2025-09-30 09:53:05 +08:00 committed by GitHub
parent 3cc59a0d69
commit 079cd97c0a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
internal/util/sessionutil/session_util_test.go
View File

@ -196,18 +196,27 @@ func TestUpdateSessions(t *testing.T) {
sessionEvents := []*SessionEvent{}
addEventLen := 0
delEventLen := 0
eventLength := len(eventCh)
for i := 0; i < eventLength; i++ {
sessionEvent := <-eventCh
if sessionEvent.EventType == SessionAddEvent {
addEventLen++
ch := time.After(time.Second * 5)
LOOP:
for {
select {
case <-ch:
t.FailNow()
case sessionEvent := <-eventCh:
if sessionEvent.EventType == SessionAddEvent {
addEventLen++
}
if sessionEvent.EventType == SessionDelEvent {
delEventLen++
}
sessionEvents = append(sessionEvents, sessionEvent)
if len(sessionEvents) == 20 {
break LOOP
}
}
if sessionEvent.EventType == SessionDelEvent {
delEventLen++
}
sessionEvents = append(sessionEvents, sessionEvent)
}
assert.Equal(t, len(sessionEvents), 20)
assert.Equal(t, addEventLen, 10)
assert.Equal(t, delEventLen, 10)
}