From 2e26d28a12e7bdfb8be84403e890d789ca32724f Mon Sep 17 00:00:00 2001 From: starlord Date: Wed, 25 Sep 2019 19:24:37 +0800 Subject: [PATCH] MS-590 Refine cmake code to support cpplint Former-commit-id: 352431bc44645574c96d28b5c46966ed85a69288 --- cpp/CHANGELOG.md | 1 + cpp/README.md | 21 ++++++++++++++++----- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/cpp/CHANGELOG.md b/cpp/CHANGELOG.md index d2a25d18f2..76e6ec2f3b 100644 --- a/cpp/CHANGELOG.md +++ b/cpp/CHANGELOG.md @@ -30,6 +30,7 @@ Please mark all change in change log and use the ticket from JIRA. - MS-569 - Complete the NOTICE.md - MS-575 - Add Clang-format & Clang-tidy & Cpplint - MS-586 - Remove BUILD_FAISS_WITH_MKL option +- MS-590 - Refine cmake code to support cpplint # Milvus 0.4.0 (2019-09-12) diff --git a/cpp/README.md b/cpp/README.md index 5c7a1d280c..7c3d28e580 100644 --- a/cpp/README.md +++ b/cpp/README.md @@ -25,7 +25,7 @@ Keep up-to-date with newest releases and latest updates by reading [Releases](ht The data is stored and computed on a distributed architecture. This lets you scale data sizes up and down without redesigning the system. ## Architecture -![Milvus_arch](https://www.milvus-io/docs/master/assets/milvus_arch.png) +![Milvus_arch](https://milvus.io/docs/assets/milvus_arch.png) ## Get started @@ -44,10 +44,12 @@ Use Docker to install Milvus is a breeze. See the [Milvus install guide](https:/ ```shell # Install tools Centos7 : -$ yum install gfortran qt4 flex bison mysql-devel mysql +$ yum install gfortran qt4 flex bison +$ yum install mysql-devel mysql Ubuntu16.04 : -$ sudo apt-get install gfortran qt4-qmake flex bison libmysqlclient-dev mysql-client +$ sudo apt-get install gfortran qt4-qmake flex bison +$ sudo apt-get install libmysqlclient-dev mysql-client ``` @@ -96,12 +98,21 @@ please reinstall CMake with curl: $ sudo make install ``` +##### code format and linting + +```shell +CentOS 7: +$ yum install clang +Ubuntu 16.04: +$ sudo apt-get install clang-format clang-tidy + +$ ./build.sh -l +``` + ##### Run unit test ```shell $ ./build.sh -u -or -$ ./build.sh --unittest ``` ##### Run code coverage