From 020f109dd899cfc097a9047ca2ee94fa99a683da Mon Sep 17 00:00:00 2001 From: groot Date: Fri, 10 Sep 2021 16:41:48 +0800 Subject: [PATCH] Add unittest for rootcoord util (#7688) Signed-off-by: yhmo --- internal/rootcoord/util_test.go | 39 ++++++++++++++++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/internal/rootcoord/util_test.go b/internal/rootcoord/util_test.go index 363d8ed8f3..a97c5a7754 100644 --- a/internal/rootcoord/util_test.go +++ b/internal/rootcoord/util_test.go @@ -14,13 +14,14 @@ package rootcoord import ( "testing" + "github.com/milvus-io/milvus/internal/msgstream" "github.com/milvus-io/milvus/internal/proto/commonpb" "github.com/milvus-io/milvus/internal/proto/etcdpb" "github.com/milvus-io/milvus/internal/proto/schemapb" "github.com/stretchr/testify/assert" ) -func TestEqualKeyPairArray(t *testing.T) { +func Test_EqualKeyPairArray(t *testing.T) { p1 := []*commonpb.KeyValuePair{ { Key: "k1", @@ -98,3 +99,39 @@ func Test_ToPhysicalChannel(t *testing.T) { assert.Equal(t, "abc__", ToPhysicalChannel("abc___defgsg")) assert.Equal(t, "abcdef", ToPhysicalChannel("abcdef")) } + +func Test_EncodeMsgPositions(t *testing.T) { + mp := &msgstream.MsgPosition{ + ChannelName: "test", + MsgID: []byte{1, 2, 3}, + } + + str, err := EncodeMsgPositions([]*msgstream.MsgPosition{}) + assert.Empty(t, str) + assert.Nil(t, err) + + mps := []*msgstream.MsgPosition{mp} + str, err = EncodeMsgPositions(mps) + assert.NotEmpty(t, str) + assert.Nil(t, err) +} + +func Test_DecodeMsgPositions(t *testing.T) { + mp := &msgstream.MsgPosition{ + ChannelName: "test", + MsgID: []byte{1, 2, 3}, + } + + str, err := EncodeMsgPositions([]*msgstream.MsgPosition{mp}) + assert.Nil(t, err) + + mpOut := make([]*msgstream.MsgPosition, 1) + err = DecodeMsgPositions(str, &mpOut) + assert.Nil(t, err) + + err = DecodeMsgPositions("", &mpOut) + assert.Nil(t, err) + + err = DecodeMsgPositions("null", &mpOut) + assert.Nil(t, err) +}