From 017fd7bc25de61734bb2af39e4edecf35e522d82 Mon Sep 17 00:00:00 2001 From: "yihao.dai" Date: Tue, 21 May 2024 16:13:39 +0800 Subject: [PATCH] enhance: Select L2 segments in L0Compaction as well (#32991) /kind improvement Signed-off-by: bigsheeper --- internal/datacoord/compaction.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/datacoord/compaction.go b/internal/datacoord/compaction.go index d4d7a0ef82..87b3fdbe2c 100644 --- a/internal/datacoord/compaction.go +++ b/internal/datacoord/compaction.go @@ -322,7 +322,6 @@ func (c *compactionPlanHandler) RefreshPlan(task *compactionTask) error { // Select sealed L1 segments for LevelZero compaction that meets the condition: // dmlPos < triggerInfo.pos - // TODO: select L2 segments too sealedSegments := c.meta.SelectSegments(WithCollection(task.triggerInfo.collectionID), SegmentFilterFunc(func(info *SegmentInfo) bool { return (task.triggerInfo.partitionID == -1 || info.GetPartitionID() == task.triggerInfo.partitionID) && info.GetInsertChannel() == plan.GetChannel() && @@ -339,7 +338,7 @@ func (c *compactionPlanHandler) RefreshPlan(task *compactionTask) error { sealedSegBinlogs := lo.Map(sealedSegments, func(info *SegmentInfo, _ int) *datapb.CompactionSegmentBinlogs { return &datapb.CompactionSegmentBinlogs{ SegmentID: info.GetID(), - Level: datapb.SegmentLevel_L1, + Level: info.GetLevel(), CollectionID: info.GetCollectionID(), PartitionID: info.GetPartitionID(), }